Misa a8cedd2f91 Prevent out-of-bounds indexing with trinket/crewmate IDs ... If a trinket or crewmate ID is out-of-bounds, it will not be created. This is not only because the `collect`/`customcollect` check in entityclass::createentity() would then be out-of-bounds, but also touching it would also be out-of-bounds, too. Display trinkets will always be created if the ID is out-of-bounds. Apparently some people (@AllyTally) have been creating display trinkets with IDs of -1 in order to get a display trinket that always shows up, which is rather horrifying. But it makes sense, there's a lot more nonzero int values than there are the amount of int values that are zero, so it's fairly likely that the `collect` check will always come up to be true (nonzero). Also, it's more useful to be able to have a display trinket that always shows up without having to collect a trinket beforehand, than it is to have it not be created (because technically by default, you're already in the world where you don't have it created). Display trinkets still have their `para` set to their ID, though, and if they managed to gain an `onentity` of 1, bad things could happen... So just to be sure, I added INBOUNDS checks to crewmates and trinkets in entityclass::updateentities() so no UB will happen if you collect a crewmate/trinket with an out-of-bounds ID. Also, I de-duplicated the `collect`/`customcollect` setting, too.		2020-06-15 21:28:21 -04:00
..
BinaryBlob.cpp	Maybe check the right size m8	2020-06-14 22:44:34 -04:00
BinaryBlob.h	Sigh.	2020-06-15 07:37:05 -04:00
BlockV.cpp	Remove blockclass::clear(), simplify blockclass initializations	2020-04-03 23:28:47 -04:00
BlockV.h	Remove blockclass::clear(), simplify blockclass initializations	2020-04-03 23:28:47 -04:00
editor.cpp	Support hex entities in metadata	2020-06-15 20:32:10 -04:00
editor.h	Remove another header initialization	2020-06-12 19:11:48 -04:00
Ent.cpp	Remove entclass::clear(), simplify entclass initializations	2020-04-03 23:28:47 -04:00
Ent.h	Remove entclass::clear(), simplify entclass initializations	2020-04-03 23:28:47 -04:00
Entity.cpp	Prevent out-of-bounds indexing with trinket/crewmate IDs	2020-06-15 21:28:21 -04:00
Entity.h	Prevent removing the player entity	2020-06-13 15:41:44 -04:00
Enums.h	Hello WWWWWWorld!	2020-01-08 10:37:50 -05:00
FileSystemUtils.cpp	Like the thing I did but the opposite	2020-06-12 16:21:45 -04:00
FileSystemUtils.h	Remove TinyXML-1	2020-06-12 15:08:29 -04:00
Finalclass.cpp	Statically allocate level arrays	2020-05-29 10:21:25 -04:00
Finalclass.h	Refactor Finalclass.cpp to not use strings for tilemaps	2020-05-17 22:03:29 -04:00
Game.cpp	Fix time trial result displaying 00:60 instead of 01:00	2020-06-14 21:51:41 -04:00
Game.h	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
GOGNetwork.c	Add support for multiple Network backends, stub in GOGNetwork	2020-01-13 11:15:22 -05:00
Graphics.cpp	Make elephant not be flashy if screen effects are disabled	2020-06-15 15:19:50 -07:00
Graphics.h	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
GraphicsResources.cpp	Fix some leaks	2020-06-07 22:40:03 -04:00
GraphicsResources.h	Fix some leaks	2020-06-07 22:40:03 -04:00
GraphicsUtil.cpp	Fix mixed indentation in GraphicsUtil.cpp	2020-04-03 10:40:50 -04:00
GraphicsUtil.h	Hello WWWWWWorld!	2020-01-08 10:37:50 -05:00
Input.cpp	Guard all cases obj.getplayer() is used unchecked	2020-06-12 23:55:48 -04:00
Input.h	Remove global args from Input.cpp	2020-04-03 10:40:50 -04:00
KeyPoll.cpp	Remove passing around pointer to gameScreen from KeyPoll::Poll()	2020-06-13 14:50:33 -04:00
KeyPoll.h	Remove passing around pointer to gameScreen from KeyPoll::Poll()	2020-06-13 14:50:33 -04:00
Labclass.cpp	Statically allocate level arrays	2020-05-29 10:21:25 -04:00
Labclass.h	Refactor Labclass.cpp to not use strings for tilemaps	2020-05-17 22:03:29 -04:00
Logic.cpp	Guard all cases obj.getcompanion() is used unchecked	2020-06-12 23:55:48 -04:00
Logic.h	Merge towerlogic() into gamelogic()	2020-04-26 19:07:40 -04:00
main.cpp	Remove passing around pointer to gameScreen from KeyPoll::Poll()	2020-06-13 14:50:33 -04:00
MakeAndPlay.h	Re-comment out #define MAKEANDPLAY	2020-02-09 10:42:03 -05:00
Map.cpp	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
Map.h	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
Maths.h	Hello WWWWWWorld!	2020-01-08 10:37:50 -05:00
Music.cpp	Add bounds checks to script commands that didn't have them	2020-06-13 01:24:42 -04:00
Music.h	Don't leak binaryBlob	2020-06-07 22:40:03 -04:00
Network.c	Allow for conditional building of Steam and GOG APIs	2020-06-01 14:21:06 -04:00
Network.h	Add support for multiple Network backends, stub in GOGNetwork	2020-01-13 11:15:22 -05:00
Otherlevel.cpp	Statically allocate level arrays	2020-05-29 10:21:25 -04:00
Otherlevel.h	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
preloader.cpp	Only render screen effects on the title screen and in-game	2020-04-27 15:07:58 -04:00
preloader.h	Remove global args from preloader.cpp	2020-04-03 10:40:50 -04:00
Render.cpp	Guard all cases obj.getplayer() is used unchecked	2020-06-12 23:55:48 -04:00
Render.h	Merge towerrender() into gamerender()	2020-04-26 19:07:40 -04:00
Screen.cpp	Move gameScreen off of the stack and onto the heap	2020-06-13 14:50:33 -04:00
Screen.h	Move gameScreen off of the stack and onto the heap	2020-06-13 14:50:33 -04:00
Script.cpp	Add bounds checks to script commands that didn't have them	2020-06-13 01:24:42 -04:00
Script.h	Refactor custom scripts to not be stored in one giant vector of lines	2020-06-11 22:13:52 -04:00
Scripts.cpp	Remove include guards from Scripts.cpp and TerminalScripts.cpp	2020-06-11 22:13:52 -04:00
SoundSystem.cpp	Revert "Add destructor for SoundTrack/MusicTrack (and explicitly define move constructor to prevent double-free)"	2020-06-07 22:40:03 -04:00
SoundSystem.h	Revert "Add destructor for SoundTrack/MusicTrack (and explicitly define move constructor to prevent double-free)"	2020-06-07 22:40:03 -04:00
Spacestation2.cpp	Statically allocate Prize for the Reckless tilemap	2020-05-29 19:39:05 -04:00
Spacestation2.h	Refactor Spacestation2.cpp to not use strings for tilemaps	2020-05-17 22:03:29 -04:00
SteamNetwork.c	Fix build on DragonFlyBSD	2020-04-23 23:35:33 -04:00
TerminalScripts.cpp	Remove include guards from Scripts.cpp and TerminalScripts.cpp	2020-06-11 22:13:52 -04:00
Textbox.cpp	Remove textboxclass's firstcreate and clear, simplify initializations	2020-04-03 23:28:47 -04:00
Textbox.h	Remove textboxclass's firstcreate and clear, simplify initializations	2020-04-03 23:28:47 -04:00
Tower.cpp	Remove now-unused fillbackground/fillcontents/fillminitower from Tower	2020-05-17 22:03:29 -04:00
Tower.h	Remove i/j/k attributes from classes that don't need them	2020-06-14 14:37:29 -04:00
UtilityClass.cpp	Support hex entities in metadata	2020-06-15 20:32:10 -04:00
UtilityClass.h	Support hex entities in metadata	2020-06-15 20:32:10 -04:00
WarpClass.cpp	Statically allocate level arrays	2020-05-29 10:21:25 -04:00
WarpClass.h	Refactor WarpClass.cpp to not use strings for tilemaps	2020-05-17 22:03:29 -04:00