1
0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-06-29 07:58:30 +02:00
VVVVVV/desktop_version/src
Misa 1b04cb5dd6 Fix crewmate-found text boxes overlapping in flip mode
The problem was that the code seemed to be wrongly copy-pasted from the
code for generating the trinket-found text boxes (to the point where
even the comment for the crewmate-found text boxes didn't get changed
from "//Found a trinket!").

For the trinket-found text boxes, they use y-positions 85 and 135 if not
in flip mode, and y-positions 105 and 65 if the game IS in flip mode.
These text boxes are positioned correctly in flip mode.

However, for the crewmate-found text boxes, they use y-positions 85 and
135 if not in flip mode, as usual, but they use y-positions 105 and 135
if the game IS in flip mode. Looks like someone forgot to change the
second y-position when copy-pasting code around.

Which is actually a bit funny, because I can conclude from this that it
seems like the code to position these text boxes in flip mode was
bolted-on AFTER the initial code of these text boxes was written.

I can also conclude (hot take incoming) that basically no one actually
ever tested this game in flip mode (but that was already evident, given
TerryCavanagh/VVVVVV#140, less strongly TerryCavanagh/VVVVVV#141, and
TerryCavanagh/VVVVVV#142 is another flip-mode-related bug which I guess
sorta kinda doesn't really count since text outline wasn't enabled until
2.3?).

So I fixed the second y-position to be 65, just like the y-position the
trinket text boxes use. I even took the opportunity to fix the comment
to say "//Found a crewmate!" instead of "//Found a trinket!".
2020-02-16 09:30:00 -05:00
..
BinaryBlob.cpp Fix warnings raised by GCC 8 2020-01-11 08:53:32 -05:00
BinaryBlob.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
BlockV.cpp Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
BlockV.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
editor.cpp Support pre-C++11 compilers 2020-02-11 06:02:35 -05:00
editor.h Support pre-C++11 compilers 2020-02-11 06:02:35 -05:00
Ent.cpp Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Ent.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Entity.cpp Make tiles in tower mode behave consistently with tower tileset elsewhere 2020-02-05 22:08:48 +01:00
Entity.h Make obj accessible from everywhere 2020-01-31 15:53:29 -08:00
Enums.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
FileSystemUtils.cpp Add -basedir option to specify base user directory (#154) 2020-02-08 18:49:03 -05:00
FileSystemUtils.h Add -basedir option to specify base user directory (#154) 2020-02-08 18:49:03 -05:00
Finalclass.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
Finalclass.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Game.cpp Fix crewmate-found text boxes overlapping in flip mode 2020-02-16 09:30:00 -05:00
Game.h Use dynamic credits lists for main menu credits screens (and add GitHub contributors) (#160) 2020-02-11 23:45:58 -05:00
GOGNetwork.c Add support for multiple Network backends, stub in GOGNetwork 2020-01-13 11:15:22 -05:00
Graphics.cpp Use uint32_t instead of char32_t 2020-02-11 06:02:35 -05:00
Graphics.h Use uint32_t instead of char32_t 2020-02-11 06:02:35 -05:00
GraphicsResources.cpp Allow using help/graphics/music/game/key/map/obj everywhere 2020-01-29 07:58:23 -05:00
GraphicsResources.h Allow using help/graphics/music/game/key/map/obj everywhere 2020-01-29 07:58:23 -05:00
GraphicsUtil.cpp Make "[Press ENTER to return to editor]" fade out after a bit 2020-02-09 22:31:33 -04:00
GraphicsUtil.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Input.cpp Use dynamic credits lists for main menu credits screens (and add GitHub contributors) (#160) 2020-02-11 23:45:58 -05:00
Input.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
KeyPoll.cpp Add support for Unicode rendering (#47) 2020-01-31 13:25:37 -05:00
KeyPoll.h Allow using help/graphics/music/game/key/map/obj everywhere 2020-01-29 07:58:23 -05:00
Labclass.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
Labclass.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Logic.cpp Add option to compile without the level editor 2020-02-09 23:31:44 -05:00
Logic.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
main.cpp Add option to allow custom levels when the editor is disabled 2020-02-09 23:31:44 -05:00
MakeAndPlay.h Re-comment out #define MAKEANDPLAY 2020-02-09 10:42:03 -05:00
Map.cpp Add option to allow custom levels when the editor is disabled 2020-02-09 23:31:44 -05:00
Map.h Add option to allow custom levels when the editor is disabled 2020-02-09 23:31:44 -05:00
Maths.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Music.cpp Fixed some music bugs 2020-02-12 21:52:25 -05:00
Music.h Allow using help/graphics/music/game/key/map/obj everywhere 2020-01-29 07:58:23 -05:00
Network.c int32_t > int 2020-01-13 11:27:16 -05:00
Network.h Add support for multiple Network backends, stub in GOGNetwork 2020-01-13 11:15:22 -05:00
Otherlevel.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
Otherlevel.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
preloader.cpp Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
preloader.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Screen.cpp Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Screen.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Script.cpp Add option to allow custom levels when the editor is disabled 2020-02-09 23:31:44 -05:00
Script.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Scripts.cpp Fix undefined behavior when activating scripts 2020-02-08 00:10:56 -05:00
SoundSystem.cpp add myself to the contributors file, fix formatting 2020-01-10 15:07:29 -07:00
SoundSystem.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Spacestation2.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
Spacestation2.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
SteamNetwork.c Untested Haiku port? 2020-01-13 23:31:14 -05:00
TerminalScripts.cpp Correct capitalization of song names 2020-01-15 22:05:37 -08:00
Textbox.cpp Add support for Unicode rendering (#47) 2020-01-31 13:25:37 -05:00
Textbox.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
titlerender.cpp Use dynamic credits lists for main menu credits screens (and add GitHub contributors) (#160) 2020-02-11 23:45:58 -05:00
titlerender.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
Tower.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
Tower.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00
UtilityClass.cpp Abstract UtilityClass::number() to be more generic 2020-01-23 10:00:26 -05:00
UtilityClass.h Allow using help/graphics/music/game/key/map/obj everywhere 2020-01-29 07:58:23 -05:00
WarpClass.cpp Initialize level data with 0s in M&P 2020-02-08 23:54:20 -05:00
WarpClass.h Hello WWWWWWorld! 2020-01-08 10:37:50 -05:00