mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-12-22 17:49:43 +01:00
Code Issues Releases Wiki Activity

Fix bug with displaying translucent pixels incorrectly

Browse source 
For a long time, VVVVVV has had an issue where if you used custom
graphics with translucent pixels (i.e. pixels whose opacity was neither
0% nor 100%, but somewhere between 0% and 100%), those pixels would end
up looking very ugly. They seemed to be overlaid on top of some weird
blue color, instead of actually being translucent.

This bug only occurred when in-game and not in towermode. So, most of
the time, basically. The translucent pixels only displayed properly
inside the Tower, both minitowers, and the editor (when not
playtesting).

I traced this down to the use of the magic number 0xDEADBEEF in
Graphics::drawmap() and Graphics::drawfinalmap(). Looks like someone had
fun finding a color. Was it you, simoroth? Anyway, I've changed it so it
simply uses 0 instead. Note that this magic number needs to be changed
for BOTH FillRect() and OverlaySurfaceKeyed(), or else the game's
background will be some random solid color instead of actually being
drawn properly.
This commit is contained in:
Info Teddy 2020-01-21 20:02:21 -08:00 committed by Ethan Lee
parent b6ca9ea039
commit 794ef29638
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
desktop_version/src/Graphics.cpp
View file

@ -2342,7 +2342,7 @@ void Graphics::drawmap( mapclass& map )
///TODO forground once; ///TODO forground once;
if (!foregrounddrawn) if (!foregrounddrawn)
{ {
FillRect(foregroundBuffer, 0xDEADBEEF); FillRect(foregroundBuffer, 0x00000000);
if(map.tileset==0) if(map.tileset==0)
{ {
for (j = 0; j < 29+map.extrarow; j++) for (j = 0; j < 29+map.extrarow; j++)
@ -2375,7 +2375,7 @@ void Graphics::drawmap( mapclass& map )
} }
foregrounddrawn = true; foregrounddrawn = true;
} }
OverlaySurfaceKeyed(foregroundBuffer, backBuffer, 0xDEADBEEF); OverlaySurfaceKeyed(foregroundBuffer, backBuffer, 0x00000000);
//SDL_BlitSurface(foregroundBuffer, NULL, backBuffer, NULL); //SDL_BlitSurface(foregroundBuffer, NULL, backBuffer, NULL);
} }
@ -2398,7 +2398,7 @@ void Graphics::drawfinalmap(mapclass & map)
} }
if (!foregrounddrawn) { if (!foregrounddrawn) {
FillRect(foregroundBuffer, 0xDEADBEEF); FillRect(foregroundBuffer, 0x00000000);
if(map.tileset==0){ if(map.tileset==0){
for (int j = 0; j < 29+map.extrarow; j++) { for (int j = 0; j < 29+map.extrarow; j++) {
for (int i = 0; i < 40; i++) { for (int i = 0; i < 40; i++) {
@ -2417,7 +2417,7 @@ void Graphics::drawfinalmap(mapclass & map)
foregrounddrawn=true; foregrounddrawn=true;
} }
OverlaySurfaceKeyed(foregroundBuffer, backBuffer, 0xDEADBEEF); OverlaySurfaceKeyed(foregroundBuffer, backBuffer, 0x00000000);
} }
void Graphics::drawtowermap( mapclass& map ) void Graphics::drawtowermap( mapclass& map )