mirror of
https://github.com/TerryCavanagh/VVVVVV.git
synced 2024-06-28 23:48:30 +02:00
dea77e98fa
This fixes a bug where the wrong music can play on the title screen, as reported by AllyTally on Discord. The bug can be triggered by triggering a room transition right as game.quittomenu() is called (which is easiest to achieve by placing the player on an oscillating/"out of bounds" room border in a custom level so they go back and forth between two rooms every frame, and triggering gamestate 1013, which starts a fadeout to menu if all custom crewmates are rescued). When this happens, game.quittomenu() calls script.hardreset(), but the rest of the frame still executes, even though we set game.gamestate to TITLEMODE too (because game.quittomenu() was called by game.updatestate() which was called by gamelogic(), and game.gamestate is only checked at the start of the frame). This ends up triggering a room transition, and since map.custommode is guaranteed to now be off (because of script.hardreset()), the main game music area code kicks in, and plays something that isn't Presenting VVVVVV. The bug here is that we're resetting too early when we still have the rest of an in-game frame to execute. So, instead, we should only reset at the end of the frame, and this can be achieved with a defer callback. |
||
|---|---|---|
| .github | ||
| desktop_version | ||
| mobile_version | ||
| third_party | ||
| tools | ||
| .gitattributes | ||
| .gitmodules | ||
| License exceptions.md | ||
| LICENSE.md | ||
| README.md | ||
This is the source code to VVVVVV, version 2.0+. For more context about this release, see the announcement on Terry's blog!
License
VVVVVV's source code is made available under a custom license. See LICENSE.md for more details.
In general, if you're interested in creating something that falls outside the license terms, get in touch with Terry and we'll talk about it!
Authors
- Created by Terry Cavanagh
- Room Names by Bennett Foddy
- Music by Magnus Pålsson
- Metal Soundtrack by FamilyJules
- 2.0 Update (C++ Port) by Simon Roth
- 2.2 Update (SDL2/PhysicsFS/Steamworks port) by Ethan Lee
- Beta Testing by Sam Kaplan and Pauli Kohberger
- Ending Picture by Pauli Kohberger
Versions
There are two versions of the VVVVVV source code available - the desktop version (based on the C++ port, and currently live on Steam), and the mobile version (based on a fork of the original flash source code, and currently live on iOS and Android).