mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-12-23 01:59:43 +01:00
Code Issues Releases Wiki Activity

Retype testwallsy's tx and ty to be ints, not floats

Browse source 
I have no idea why they were floats in the first place. They are
coordinates, and coordinates are integer positions in this game. They
get converted to float only to be explicitly `static_cast`ed back to
ints in `testwallsy`.
This commit is contained in:
Misa 2022-12-11 11:00:20 -08:00
parent 12820473db
commit ec520838df
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
desktop_version/src/Entity.cpp
View file

@ -4473,7 +4473,7 @@ bool entityclass::testwallsx( int t, int tx, int ty, const bool skipdirblocks )
return true; return true;
} }
bool entityclass::testwallsy( int t, float tx, float ty ) bool entityclass::testwallsy( int t, int tx, int ty )
{ {
if (!INBOUNDS_VEC(t, entities)) if (!INBOUNDS_VEC(t, entities))
{ {
@ -4482,8 +4482,8 @@ bool entityclass::testwallsy( int t, float tx, float ty )
} }
SDL_Rect temprect; SDL_Rect temprect;
temprect.x = static_cast<int>(tx) + entities[t].cx; temprect.x = tx + entities[t].cx;
temprect.y = static_cast<int>(ty) + entities[t].cy; temprect.y = ty + entities[t].cy;
temprect.w = entities[t].w; temprect.w = entities[t].w;
temprect.h = entities[t].h; temprect.h = entities[t].h;

2
desktop_version/src/Entity.h
View file

@ -155,7 +155,7 @@ public:
bool testwallsx(int t, int tx, int ty, bool skipdirblocks); bool testwallsx(int t, int tx, int ty, bool skipdirblocks);
bool testwallsy(int t, float tx, float ty); bool testwallsy(int t, int tx, int ty);
void applyfriction(int t, float xrate, float yrate); void applyfriction(int t, float xrate, float yrate);