mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-12-23 10:09:43 +01:00
Code Issues Releases Wiki Activity

Add bounds checks to scriptclass::tokenize()

Browse source 
It could index the `words` array out-of-bounds if there were more than
40 arguments in a command. Not like that would ever happen, but it's
still good to be sure.
This commit is contained in:
Misa 2020-07-02 16:09:55 -07:00 committed by Ethan Lee
parent c7774a3eb9
commit c3e7ddca9c
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
desktop_version/src/Script.cpp
View file

@ -56,9 +56,13 @@ void scriptclass::tokenize( std::string t )
{ {
tempword += currentletter; tempword += currentletter;
} }
if (j >= (int) SDL_arraysize(words))
{
break;
}
} }
if (tempword != "") if (tempword != "" && j < (int) SDL_arraysize(words))
{ {
words[j] = tempword; words[j] = tempword;
} }