mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-06-28 15:38:30 +02:00
Code Issues Releases Wiki Activity

Remove default arguments from createtextbox()

Browse Source 
These default arguments are never used anywhere. And if they were used
anywhere, it'd be better to explicitly say 255,255,255 than make readers
have to look at the header file to see what these default to. Also, this
creates four different overloads of createtextbox(), instead of only
two - but we ought to not be using function overloading anyway.
This commit is contained in:
Misa 2021-03-19 16:41:41 -07:00 committed by Ethan Lee
parent d5ed49d8dc
commit b7ca408076
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
desktop_version/src/Graphics.cpp
View File

@ -1274,7 +1274,7 @@ void Graphics::textboxadjust(void)
}
void Graphics::createtextbox( std::string t, int xp, int yp, int r/*= 255*/, int g/*= 255*/, int b /*= 255*/ )
void Graphics::createtextbox( std::string t, int xp, int yp, int r, int g, int b)
{
m = textbox.size();

2
desktop_version/src/Graphics.h
View File

@ -51,7 +51,7 @@ public:
void setwarprect(int a, int b, int c, int d);
void createtextbox(std::string t, int xp, int yp, int r= 255, int g= 255, int b = 255);
void createtextbox(std::string t, int xp, int yp, int r, int g, int b);
void textboxcenterx(void);