VVVVVV/desktop_version/src/ScreenSettings.h

#ifndef SCREENSETTINGS_H
#define SCREENSETTINGS_H

enum
{
    SCALING_LETTERBOX = 0,
    SCALING_STRETCH = 1,
    SCALING_INTEGER = 2,
    NUM_SCALING_MODES
};

struct ScreenSettings
{
    int windowDisplay;
    int windowWidth;
    int windowHeight;
    bool fullscreen;
    bool useVsync;
    int scalingMode;
    bool linearFilter;
    bool badSignal;
};

void ScreenSettings_default(struct ScreenSettings* _this);

#endif /* SCREENSETTINGS_H */
Factor out screen settings to ScreenSettings struct It's a bit annoying to pass each screen setting individually, would be nice if we could just wrap it up in a nice struct and pass that instead. 2020-11-13 01:29:11 +01:00			`#ifndef SCREENSETTINGS_H`
			`#define SCREENSETTINGS_H`

Add and use scaling mode enum This enum is to just make each mode be readable, instead of mysterious 0/1/2 values. It's not a strictly-typed enum because we still have to serialize it as ints in the XML, but it's better than just leaving them as ints. This also adds a NUM_SCALING_MODES enum, so we don't have to hardcode that 3 when cycling scaling modes anymore. 2021-12-26 08:05:14 +01:00			`enum`
			`{`
			`SCALING_LETTERBOX = 0,`
			`SCALING_STRETCH = 1,`
			`SCALING_INTEGER = 2,`
			`NUM_SCALING_MODES`
			`};`

Factor out screen settings to ScreenSettings struct It's a bit annoying to pass each screen setting individually, would be nice if we could just wrap it up in a nice struct and pass that instead. 2020-11-13 01:29:11 +01:00			`struct ScreenSettings`
			`{`
Store display index of window to settings I have this annoying issue where the game will open on the wrong monitor in fullscreen mode, because that monitor is considered to be display 0, whereas the primary monitor I want is display 1. To mitigate this somewhat, the game now stores the display index that it was closed on, and will save it to settings. Then the next time the game opens, it will open on that display index. This should work pretty well as long as you aren't changing your monitor setup constantly. Of course, none of this applies if your window manager is busted. For example, on GNOME Wayland, which is what I use, in windowed mode the game will always open on the monitor the cursor is on, and it won't even be centered in the monitor. But it works fine if I use XWayland via SDL_VIDEODRIVER=x11. 2023-03-21 08:23:42 +01:00			`int windowDisplay;`
Untabify every single file YOLO. This is a repeat of #642. As before, I just did rg -l '\t' \| xargs -n 1 sed -i -e 's/\t/ /g' inside the desktop_version/ folder. 2021-09-07 03:56:39 +02:00			`int windowWidth;`
			`int windowHeight;`
			`bool fullscreen;`
			`bool useVsync;`
Rename stretch mode to scaling mode internally It's been long overdue that this variable be named properly. 2.2 added integer scaling mode (thanks Ethan), 2.3 renamed it to scaling mode. Now 2.4 will properly call it what it is so people won't be confused by it. The ScreenSettings struct member is renamed from stretch to scalingMode along with the Screen class member being renamed, as well as the toggleStretchMode function being renamed to toggleScalingMode as well. Unfortunately, due to compatibility, we can't change the <stretch> XML tag. 2021-12-23 04:54:59 +01:00			`int scalingMode;`
Untabify every single file YOLO. This is a repeat of #642. As before, I just did rg -l '\t' \| xargs -n 1 sed -i -e 's/\t/ /g' inside the desktop_version/ folder. 2021-09-07 03:56:39 +02:00			`bool linearFilter;`
			`bool badSignal;`
Factor out screen settings to ScreenSettings struct It's a bit annoying to pass each screen setting individually, would be nice if we could just wrap it up in a nice struct and pass that instead. 2020-11-13 01:29:11 +01:00			`};`

De-C++-ify `struct ScreenSettings` This includes: - Removing the constructor in favor of actually being able to see that there's an actual function called being made initializing the struct - Removing the use of a reference in Screen::init() in favor of using a pointer - Adding the struct qualifier everywhere (it's not much typing), although technically you could typedef it in C, but I'd rather much not typedef just to remove a tag qualifier 2021-12-25 09:18:51 +01:00			`void ScreenSettings_default(struct ScreenSettings* _this);`

Factor out screen settings to ScreenSettings struct It's a bit annoying to pass each screen setting individually, would be nice if we could just wrap it up in a nice struct and pass that instead. 2020-11-13 01:29:11 +01:00			`#endif /* SCREENSETTINGS_H */`