Merge pull request #19 from erikarvstedt/improve-target-opts

Improve deploy target options

lib/default.nix

@@ -43,16 +43,22 @@ let {
       lib.elem target.host [origin.host "localhost"];
 
     mkTarget = s: let
-      default = defVal: val: if val != null then val else defVal;
       parse = lib.match "(([^@]*)@)?(([^:/]+))?(:([^/]+))?(/.*)?" s;
       elemAt' = xs: i: if lib.length xs > i then lib.elemAt xs i else null;
-    in if lib.isString s then {
+      filterNull = lib.filterAttrs (n: v: v != null);
-      user = default (lib.getEnv "LOGNAME") (elemAt' parse 1);
+    in {
-      host = default (lib.maybeEnv "HOSTNAME" lib.getHostName) (elemAt' parse 3);
+      user = lib.getEnv "LOGNAME";
-      port = default "22" /* "ssh"? */ (elemAt' parse 5);
+      host = lib.maybeEnv "HOSTNAME" lib.getHostName;
-      path = default "/var/src" /* no default? */ (elemAt' parse 6);
+      port = "22";
+      path = "/var/src";
       sudo = false;
-    } else s;
+      extraOptions = [];
+    } // (if lib.isString s then filterNull {
+      user = elemAt' parse 1;
+      host = elemAt' parse 3;
+      port = elemAt' parse 5;
+      path = elemAt' parse 6;
+    } else s);
 
     shell = let
       isSafeChar = lib.testString "[-+./0-9:=A-Z_a-z]";

pkgs/krops/default.nix

@@ -23,6 +23,7 @@ in
         (lib.optionals (target.user != "") ["-l" target.user])
         "-p" target.port
         "-t"
+        target.extraOptions
         target.host
         (if target.sudo then "sudo ${command}" else command)])}
     '';

pkgs/populate/default.nix

@@ -194,6 +194,7 @@ let
     "-o" "ControlPersist=no"
     "-p" target.port
     "-T"
+    target.extraOptions
   ]);
 
 in