eeva/jamulus
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

added comments

Browse source
This commit is contained in:
Volker Fischer 2020-06-23 17:28:19 +02:00
parent 5f579d7b96
commit 600333a415
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -30,9 +30,6 @@
- bug fix: server window stop updating after minimized, coded by AronVietti (#355, #383) - bug fix: server window stop updating after minimized, coded by AronVietti (#355, #383)
TODO add "Update Jamulus Version" in register response errors
TODO add new register message which contains version and, e.g., max number of clients
TODO clip LED on channel faders goes on too early (compare to input level meter clip LED) TODO clip LED on channel faders goes on too early (compare to input level meter clip LED)
-> only 3 of 4 bits of the channel level protocol are actually used, one bit is wasted -> only 3 of 4 bits of the channel level protocol are actually used, one bit is wasted
@ -45,6 +42,8 @@ TODO support clip indicator for bar meter as well
TODO the new translation loading does not work on MacOS TODO the new translation loading does not work on MacOS
TODO add new register message which contains version and, e.g., max number of clients
TODO https://github.com/corrados/jamulus/issues/341#issuecomment-647172946 TODO https://github.com/corrados/jamulus/issues/341#issuecomment-647172946
- generate .qm on compile time with lrelease - generate .qm on compile time with lrelease
- download nsProcess.dll on Windows installer creation instead of put it in the repo - download nsProcess.dll on Windows installer creation instead of put it in the repo

2
src/levelmeter.cpp
View file

@ -60,7 +60,7 @@ CLevelMeter::CLevelMeter ( QWidget* parent, Qt::WindowFlags f ) :
// initialize bar meter // initialize bar meter
pBarMeter = new QProgressBar(); pBarMeter = new QProgressBar();
pBarMeter->setOrientation ( Qt::Vertical ); pBarMeter->setOrientation ( Qt::Vertical );
pBarMeter->setRange ( 0, 100 * NUM_STEPS_LED_BAR ); pBarMeter->setRange ( 0, 100 * NUM_STEPS_LED_BAR ); // use factor 100 to reduce quantization (bar is continuous)
pBarMeter->setFormat ( "" ); // suppress percent numbers pBarMeter->setFormat ( "" ); // suppress percent numbers
// setup stacked layout for meter type switching mechanism // setup stacked layout for meter type switching mechanism

1
src/protocol.cpp
View file

@ -381,6 +381,7 @@ CONNECTION LESS MESSAGES
Values of ESvrRegResult: Values of ESvrRegResult:
0 - success 0 - success
1 - failed due to central server list being full 1 - failed due to central server list being full
2 - your server version is too old
Note: the central server may send this message in response to a Note: the central server may send this message in response to a
PROTMESSID_CLM_REGISTER_SERVER request. PROTMESSID_CLM_REGISTER_SERVER request.