From 600333a415e16929354d8acc7a6e8e31bf03cec0 Mon Sep 17 00:00:00 2001 From: Volker Fischer Date: Tue, 23 Jun 2020 17:28:19 +0200 Subject: [PATCH] added comments --- ChangeLog | 5 ++--- src/levelmeter.cpp | 2 +- src/protocol.cpp | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index f5d3441a..db9eff72 100644 --- a/ChangeLog +++ b/ChangeLog @@ -30,9 +30,6 @@ - bug fix: server window stop updating after minimized, coded by AronVietti (#355, #383) -TODO add "Update Jamulus Version" in register response errors - -TODO add new register message which contains version and, e.g., max number of clients TODO clip LED on channel faders goes on too early (compare to input level meter clip LED) -> only 3 of 4 bits of the channel level protocol are actually used, one bit is wasted @@ -45,6 +42,8 @@ TODO support clip indicator for bar meter as well TODO the new translation loading does not work on MacOS +TODO add new register message which contains version and, e.g., max number of clients + TODO https://github.com/corrados/jamulus/issues/341#issuecomment-647172946 - generate .qm on compile time with lrelease - download nsProcess.dll on Windows installer creation instead of put it in the repo diff --git a/src/levelmeter.cpp b/src/levelmeter.cpp index b81433d8..e4f5897e 100755 --- a/src/levelmeter.cpp +++ b/src/levelmeter.cpp @@ -60,7 +60,7 @@ CLevelMeter::CLevelMeter ( QWidget* parent, Qt::WindowFlags f ) : // initialize bar meter pBarMeter = new QProgressBar(); pBarMeter->setOrientation ( Qt::Vertical ); - pBarMeter->setRange ( 0, 100 * NUM_STEPS_LED_BAR ); + pBarMeter->setRange ( 0, 100 * NUM_STEPS_LED_BAR ); // use factor 100 to reduce quantization (bar is continuous) pBarMeter->setFormat ( "" ); // suppress percent numbers // setup stacked layout for meter type switching mechanism diff --git a/src/protocol.cpp b/src/protocol.cpp index 5061fb88..69f0f42e 100755 --- a/src/protocol.cpp +++ b/src/protocol.cpp @@ -381,6 +381,7 @@ CONNECTION LESS MESSAGES Values of ESvrRegResult: 0 - success 1 - failed due to central server list being full + 2 - your server version is too old Note: the central server may send this message in response to a PROTMESSID_CLM_REGISTER_SERVER request.