1
0
Fork 0
mirror of https://github.com/nix-community/home-manager synced 2024-12-25 19:29:47 +01:00
home-manager/tests/modules/services/window-managers
Emily 4c0357ff87
sway: fix workspace 10 missing from default config (#4636)
workspace 10 is part of upstream's default config, but was missing in home-manager.

The initial "sway: add module" PR (02d6040003) went through multiple iterations and had workspace 10 included for a brief moment.
Until the author removed it in a force-push commenting

> Have removed the last change which added bound ${modifer}+0 to workspace number 10 as this messed up workspace numbering in sway.

The reason might have been, that sway used to sort the workspaces in the order they appeared in the config.

Attribute sets in nix are sorted, but not "naturally sorted", meaning `bindsym Mod1+0 workspace number 10` comes before `bindsym Mod1+0 workspace number 1`.

It's unclear if that's what really happened. A workaround would have been to use `lib.lists.naturalSort` in `keybindingsStr`.

But I cannot reproduce this anymore in any way.
I assume this has been fixed many years ago by now.

upstream config: 020a572ed6/config.in (L113-L134)
2024-02-10 19:59:52 +01:00
..
bspwm tests: various minor cleanups 2023-05-13 00:09:52 +02:00
herbstluftwm herbstluftwm: fix default tag renaming 2023-04-22 16:38:31 +02:00
hyprland hyprland: change plugins settings generation 2024-01-21 00:40:55 +01:00
i3 i3-sway: multiple outputs (#4223) 2023-07-14 21:25:55 +02:00
spectrwm spectrwm: add module 2022-07-25 13:42:06 +02:00
sway sway: fix workspace 10 missing from default config (#4636) 2024-02-10 19:59:52 +01:00