1
0
Fork 0
mirror of https://github.com/nix-community/home-manager synced 2024-12-28 04:39:48 +01:00
home-manager/tests/modules
Emily 4c0357ff87
sway: fix workspace 10 missing from default config (#4636)
workspace 10 is part of upstream's default config, but was missing in home-manager.

The initial "sway: add module" PR (02d6040003) went through multiple iterations and had workspace 10 included for a brief moment.
Until the author removed it in a force-push commenting

> Have removed the last change which added bound ${modifer}+0 to workspace number 10 as this messed up workspace numbering in sway.

The reason might have been, that sway used to sort the workspaces in the order they appeared in the config.

Attribute sets in nix are sorted, but not "naturally sorted", meaning `bindsym Mod1+0 workspace number 10` comes before `bindsym Mod1+0 workspace number 1`.

It's unclear if that's what really happened. A workaround would have been to use `lib.lists.naturalSort` in `keybindingsStr`.

But I cannot reproduce this anymore in any way.
I assume this has been fixed many years ago by now.

upstream config: 020a572ed6/config.in (L113-L134)
2024-02-10 19:59:52 +01:00
..
accounts tests: allow testing assertions 2021-02-07 22:48:22 +01:00
config/i18n i18n: Use glibcLocales from NixOS if possible (#2333) (#4177) 2023-07-04 11:28:25 +02:00
files tests: various minor cleanups 2023-05-13 00:09:52 +02:00
home-environment i18n: Use glibcLocales from NixOS if possible (#2333) (#4177) 2023-07-04 11:28:25 +02:00
i18n/input-method tests: reduce closure sizes 2024-02-03 19:39:45 +01:00
launchd launchd: make Launch Agents config a freeform setting 2023-03-25 23:59:58 +01:00
misc xdg-portal: add new module 2024-01-03 20:51:54 +01:00
programs zellij: use full executable path 2024-02-09 09:26:22 +01:00
services sway: fix workspace 10 missing from default config (#4636) 2024-02-10 19:59:52 +01:00
systemd systemd: avoid creating an empty user.conf 2023-11-11 00:51:53 +01:00
targets-darwin darwin: use full path to commands in activation script 2022-11-05 12:14:08 +09:00
targets-linux xdg.systemDirs: init module (#1797) 2021-05-10 20:14:42 -04:00
xresources xresources: add missing test file 2020-06-28 11:23:34 +02:00