1
0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-06-01 18:43:33 +02:00
VVVVVV/desktop_version/src/SoundSystem.cpp
Misa 6a3a1fe147
Explicitly declare void for all void parameter functions (#628)
Apparently in C, if you have `void test();`, it's completely okay to do
`test(2);`. The function will take in the argument, but just discard it
and throw it away. It's like a trash can, and a rude one at that. If you
declare it like `void test(void);`, this is prevented.

This is not a problem in C++ - doing `void test();` and `test(2);` is
guaranteed to result in a compile error (this also means that right now,
at least in all `.cpp` files, nobody is ever calling a void parameter
function with arguments and having their arguments be thrown away).
However, we may not be using C++ in the future, so I just want to lay
down the precedent that if a function takes in no arguments, you must
explicitly declare it as such.

I would've added `-Wstrict-prototypes`, but it produces an annoying
warning message saying it doesn't work in C++ mode if you're compiling
in C++ mode. So it can be added later.
2021-02-25 17:23:59 -05:00

64 lines
1.3 KiB
C++

#include "SoundSystem.h"
#include <SDL.h>
#include "FileSystemUtils.h"
MusicTrack::MusicTrack(const char* fileName)
{
m_music = Mix_LoadMUS(fileName);
m_isValid = true;
if(m_music == NULL)
{
fprintf(stderr, "Unable to load Ogg Music file: %s\n", Mix_GetError());
m_isValid = false;
}
}
MusicTrack::MusicTrack(SDL_RWops *rw)
{
m_music = Mix_LoadMUS_RW(rw, 1);
m_isValid = true;
if(m_music == NULL)
{
fprintf(stderr, "Unable to load Magic Binary Music file: %s\n", Mix_GetError());
m_isValid = false;
}
}
SoundTrack::SoundTrack(const char* fileName)
{
sound = NULL;
unsigned char *mem;
size_t length = 0;
FILESYSTEM_loadFileToMemory(fileName, &mem, &length);
if (mem == NULL)
{
fprintf(stderr, "Unable to load WAV file %s\n", fileName);
return;
}
SDL_RWops *fileIn = SDL_RWFromMem(mem, length);
sound = Mix_LoadWAV_RW(fileIn, 1);
FILESYSTEM_freeMemory(&mem);
if (sound == NULL)
{
fprintf(stderr, "Unable to load WAV file: %s\n", Mix_GetError());
}
}
SoundSystem::SoundSystem(void)
{
int audio_rate = 44100;
Uint16 audio_format = AUDIO_S16SYS;
int audio_channels = 2;
int audio_buffers = 1024;
if (Mix_OpenAudio(audio_rate, audio_format, audio_channels, audio_buffers) != 0)
{
fprintf(stderr, "Unable to initialize audio: %s\n", Mix_GetError());
SDL_assert(0 && "Unable to initialize audio!");
}
}