mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2024-12-23 01:59:43 +01:00
Code Issues Releases Wiki Activity

Fix -Wformat-security warnings

Browse source 
These warnings are kinda spammy, and they make sense in principle.
vlog_error takes a format string, so passing it an arbitrary string
(even error messages from libraries) isn't a good idea.
This commit is contained in:
Dav999-v 2021-12-05 15:50:20 +01:00 committed by Misa Elizabeth Kai
parent 6e832cae20
commit f60d2a2964
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
desktop_version/src/FileSystemUtils.cpp
View file

@ -306,7 +306,7 @@ static int setLevelDirError(const char* text, ...)
retval = SDL_vsnprintf(levelDirError, sizeof(levelDirError), text, list); retval = SDL_vsnprintf(levelDirError, sizeof(levelDirError), text, list);
va_end(list); va_end(list);
vlog_error(levelDirError); vlog_error("%s", levelDirError);
return retval; return retval;
} }

2
desktop_version/src/Graphics.cpp
View file

@ -321,7 +321,7 @@ void Graphics::updatetitlecolours(void)
SDL_snprintf(error, sizeof(error), error_fmt, #tilesheet, tile_square); \ SDL_snprintf(error, sizeof(error), error_fmt, #tilesheet, tile_square); \
SDL_snprintf(error_title, sizeof(error_title), error_title_fmt, #tilesheet); \ SDL_snprintf(error_title, sizeof(error_title), error_title_fmt, #tilesheet); \
\ \
vlog_error(error); \ vlog_error("%s", error); \
\ \
return false; \ return false; \
} }