mpo/VVVVVV
1
0
Fork 0
mirror of https://github.com/TerryCavanagh/VVVVVV.git synced 2025-02-01 21:55:01 +01:00
Code Issues Releases Wiki Activity

Use case-switch inside GCChar() instead of if-else tree

Browse source 
A case-switch here takes up less lines (at least with next-line brace
style) and doesn't repeat the 'button ==' part over and over.
This commit is contained in:
Misa 2021-02-07 13:05:24 -08:00 • committed by Ethan Lee
parent eea37046ef
commit e1ae25b29b
1 changed files with 15 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
desktop_version/src/UtilityClass.cpp
View file

@ -6,52 +6,34 @@
static const char* GCChar(const SDL_GameControllerButton button)
{
if (button == SDL_CONTROLLER_BUTTON_A)
switch (button)
{
case SDL_CONTROLLER_BUTTON_A:
return "A";
}
else if (button == SDL_CONTROLLER_BUTTON_B)
{
case SDL_CONTROLLER_BUTTON_B:
return "B";
}
else if (button == SDL_CONTROLLER_BUTTON_X)
{
case SDL_CONTROLLER_BUTTON_X:
return "X";
}
else if (button == SDL_CONTROLLER_BUTTON_Y)
{
case SDL_CONTROLLER_BUTTON_Y:
return "Y";
}
else if (button == SDL_CONTROLLER_BUTTON_BACK)
{
case SDL_CONTROLLER_BUTTON_BACK:
return "BACK";
}
else if (button == SDL_CONTROLLER_BUTTON_GUIDE)
{
case SDL_CONTROLLER_BUTTON_GUIDE:
return "GUIDE";
}
else if (button == SDL_CONTROLLER_BUTTON_START)
{
case SDL_CONTROLLER_BUTTON_START:
return "START";
}
else if (button == SDL_CONTROLLER_BUTTON_LEFTSTICK)
{
case SDL_CONTROLLER_BUTTON_LEFTSTICK:
return "L3";
}
else if (button == SDL_CONTROLLER_BUTTON_RIGHTSTICK)
{
case SDL_CONTROLLER_BUTTON_RIGHTSTICK:
return "R3";
}
else if (button == SDL_CONTROLLER_BUTTON_LEFTSHOULDER)
{
case SDL_CONTROLLER_BUTTON_LEFTSHOULDER:
return "LB";
}
else if (button == SDL_CONTROLLER_BUTTON_RIGHTSHOULDER)
{
case SDL_CONTROLLER_BUTTON_RIGHTSHOULDER:
return "RB";
default:
SDL_assert(0 && "Unhandled button!");
return NULL;
}
SDL_assert(0 && "Unhandled button!");
return NULL;
}
int ss_toi( std::string _s )