From b4226631b9b632d5b205081d6e436d11ef8040b4 Mon Sep 17 00:00:00 2001 From: Misa Date: Mon, 22 Aug 2022 21:49:01 -0700 Subject: [PATCH] Remove use of `add_definitions` I thought all of these were removed earlier but apparently not. Anyways, add_definitions is bad because it pollutes the definitions of every single target, we should be using target_compile_definitions instead. --- desktop_version/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop_version/CMakeLists.txt b/desktop_version/CMakeLists.txt index d24758fa..29211a75 100644 --- a/desktop_version/CMakeLists.txt +++ b/desktop_version/CMakeLists.txt @@ -220,7 +220,7 @@ if(NOT OFFICIAL_BUILD) add_dependencies(VVVVVV GenerateVersion) # This lets Version.h know that Version.h.out exists - add_definitions(-DVERSION_H_OUT_EXISTS) + target_compile_definitions(VVVVVV PRIVATE -DVERSION_H_OUT_EXISTS) endif() endif() @@ -236,9 +236,9 @@ if(ENABLE_WARNINGS) endif() if(CUSTOM_LEVEL_SUPPORT STREQUAL "NO_EDITOR") - add_definitions(-DNO_EDITOR) + target_compile_definitions(VVVVVV PRIVATE -DNO_EDITOR) elseif(CUSTOM_LEVEL_SUPPORT STREQUAL "DISABLED") - add_definitions(-DNO_CUSTOM_LEVELS -DNO_EDITOR) + target_compile_definitions(VVVVVV PRIVATE -DNO_CUSTOM_LEVELS -DNO_EDITOR) endif() if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")