From 943362559cb4c5cd77ea8d6bcea20d9d27921159 Mon Sep 17 00:00:00 2001
From: Dav999 <dav999.tolp@gmail.com>
Date: Fri, 21 Apr 2023 23:30:49 +0200
Subject: [PATCH] Adapt font size as needed for "Credits" title in rolling
 credits

In Italian, "Credits" is "Riconoscimenti", which runs offscreen with
the 3x font size that this title uses in the rolling credits at the end
of the game. I'm not sure if the translators saw that specific
instance, or thought the limit complaint was about the main menu button
all along (which is more prominent and *does* stick out far enough that
the complaint could plausibly have been about that, from a translator's
perspective!)

Either way, it's solved now: this string's width is now checked, and if
it will run offscreen at 3x size, it will now be displayed at 2x size
instead. The limit has been increased from 13 to 20 in the language
files accordingly.
---
 desktop_version/lang/ca/strings.xml    |  2 +-
 desktop_version/lang/de/strings.xml    |  2 +-
 desktop_version/lang/en/strings.xml    |  2 +-
 desktop_version/lang/eo/strings.xml    |  2 +-
 desktop_version/lang/es/strings.xml    |  2 +-
 desktop_version/lang/fr/strings.xml    |  2 +-
 desktop_version/lang/it/strings.xml    |  2 +-
 desktop_version/lang/nl/strings.xml    |  2 +-
 desktop_version/lang/pt_BR/strings.xml |  2 +-
 desktop_version/lang/pt_PT/strings.xml |  2 +-
 desktop_version/lang/ru/strings.xml    |  2 +-
 desktop_version/lang/tr/strings.xml    |  2 +-
 desktop_version/src/Render.cpp         | 11 ++++++++++-
 13 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/desktop_version/lang/ca/strings.xml b/desktop_version/lang/ca/strings.xml
index 09dafaa4..7c1a444a 100644
--- a/desktop_version/lang/ca/strings.xml
+++ b/desktop_version/lang/ca/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volum dels sons" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volum dels sons" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Canvia el volum dels efectes de so." explanation="" max="38*3"/>
-    <string english="Credits" translation="Crèdits" explanation="credits" max="13"/>
+    <string english="Credits" translation="Crèdits" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV és un joc de" explanation="credits" max="40"/>
     <string english="and features music by" translation="i conté música de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Noms de les sales de" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/de/strings.xml b/desktop_version/lang/de/strings.xml
index a6f3705a..f00c03d8 100644
--- a/desktop_version/lang/de/strings.xml
+++ b/desktop_version/lang/de/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="effektlautstärke" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Effektlautstärke" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Ändere die Lautstärke der Soundeffekte." explanation="" max="38*3"/>
-    <string english="Credits" translation="Mitwirkende" explanation="credits" max="13"/>
+    <string english="Credits" translation="Mitwirkende" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV ist ein Spiel von" explanation="credits" max="40"/>
     <string english="and features music by" translation="mit Musik von" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Raumnamen sind von" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/en/strings.xml b/desktop_version/lang/en/strings.xml
index 6b9a3b3f..39c51b3d 100644
--- a/desktop_version/lang/en/strings.xml
+++ b/desktop_version/lang/en/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="" explanation="audio menu option"/>
     <string english="Sound Volume" translation="" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="" explanation="" max="38*3"/>
-    <string english="Credits" translation="" explanation="credits" max="13"/>
+    <string english="Credits" translation="" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="" explanation="credits" max="40"/>
     <string english="and features music by" translation="" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/eo/strings.xml b/desktop_version/lang/eo/strings.xml
index df7b7120..ff604638 100644
--- a/desktop_version/lang/eo/strings.xml
+++ b/desktop_version/lang/eo/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="son-laŭteco" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Laŭteco de sonoj" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Ŝanĝi la laŭtecon de sonefikoj." explanation="" max="38*3"/>
-    <string english="Credits" translation="Agnoskoj" explanation="credits" max="13"/>
+    <string english="Credits" translation="Agnoskoj" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV estas ludo de" explanation="credits" max="40"/>
     <string english="and features music by" translation="kaj enhavas muzikon de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Ĉambronomoj de" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/es/strings.xml b/desktop_version/lang/es/strings.xml
index 37189b0f..982a0aa3 100644
--- a/desktop_version/lang/es/strings.xml
+++ b/desktop_version/lang/es/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volumen de sonido" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volumen de sonido" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Cambia el volumen de los efectos de sonido." explanation="" max="38*3"/>
-    <string english="Credits" translation="Créditos" explanation="credits" max="13"/>
+    <string english="Credits" translation="Créditos" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV es un juego de" explanation="credits" max="40"/>
     <string english="and features music by" translation="e incluye música de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Nombres de las salas de" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/fr/strings.xml b/desktop_version/lang/fr/strings.xml
index edc36a43..5de883e1 100644
--- a/desktop_version/lang/fr/strings.xml
+++ b/desktop_version/lang/fr/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volume des bruitages" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volume bruitages" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Modifiez le volume des bruitages." explanation="" max="38*3"/>
-    <string english="Credits" translation="Générique" explanation="credits" max="13"/>
+    <string english="Credits" translation="Générique" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV est un jeu de" explanation="credits" max="40"/>
     <string english="and features music by" translation="avec une musique de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Noms des salles par" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/it/strings.xml b/desktop_version/lang/it/strings.xml
index b7a8a73a..4a8f6ced 100644
--- a/desktop_version/lang/it/strings.xml
+++ b/desktop_version/lang/it/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volume suoni" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volume suoni" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Cambia il volume degli effetti sonori." explanation="" max="38*3"/>
-    <string english="Credits" translation="Riconoscimenti" explanation="credits" max="13"/>
+    <string english="Credits" translation="Riconoscimenti" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV è un gioco di" explanation="credits" max="40"/>
     <string english="and features music by" translation="con musiche di" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="I nomi delle stanze sono di" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/nl/strings.xml b/desktop_version/lang/nl/strings.xml
index 29f442d6..738b93fb 100644
--- a/desktop_version/lang/nl/strings.xml
+++ b/desktop_version/lang/nl/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="geluidsvolume" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Geluidsvolume" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Wijzig het volume van geluidseffecten." explanation="" max="38*3"/>
-    <string english="Credits" translation="Credits" explanation="credits" max="13"/>
+    <string english="Credits" translation="Credits" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV is een spel door" explanation="credits" max="40"/>
     <string english="and features music by" translation="en heeft muziek door" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Kamernamen door" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/pt_BR/strings.xml b/desktop_version/lang/pt_BR/strings.xml
index f3083741..3304be2d 100644
--- a/desktop_version/lang/pt_BR/strings.xml
+++ b/desktop_version/lang/pt_BR/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volume do som" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volume do som" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Altere o volume dos efeitos sonoros." explanation="" max="38*3"/>
-    <string english="Credits" translation="Créditos" explanation="credits" max="13"/>
+    <string english="Credits" translation="Créditos" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV é um jogo criado por" explanation="credits" max="40"/>
     <string english="and features music by" translation="e traz músicas de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Os nomes das salas são de" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/pt_PT/strings.xml b/desktop_version/lang/pt_PT/strings.xml
index 3dcc330a..4ed16c39 100644
--- a/desktop_version/lang/pt_PT/strings.xml
+++ b/desktop_version/lang/pt_PT/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="volume dos efeitos" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Volume dos Efeitos" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Altera o volume dos efeitos sonoros." explanation="" max="38*3"/>
-    <string english="Credits" translation="Créditos" explanation="credits" max="13"/>
+    <string english="Credits" translation="Créditos" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV foi criado por" explanation="credits" max="40"/>
     <string english="and features music by" translation="com música de" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Nome das salas por" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/ru/strings.xml b/desktop_version/lang/ru/strings.xml
index 801e78a1..6d21683a 100644
--- a/desktop_version/lang/ru/strings.xml
+++ b/desktop_version/lang/ru/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="громкость звука" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Громкость звука" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Измените громкость звуковых эффектов." explanation="" max="38*3"/>
-    <string english="Credits" translation="Авторы" explanation="credits" max="13"/>
+    <string english="Credits" translation="Авторы" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV - игра от" explanation="credits" max="40"/>
     <string english="and features music by" translation="с музыкой от" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Названия комнат от" explanation="credits" max="40"/>
diff --git a/desktop_version/lang/tr/strings.xml b/desktop_version/lang/tr/strings.xml
index f2c87b11..2e0d8f85 100644
--- a/desktop_version/lang/tr/strings.xml
+++ b/desktop_version/lang/tr/strings.xml
@@ -107,7 +107,7 @@
     <string english="sound volume" translation="ses seviyesi" explanation="audio menu option"/>
     <string english="Sound Volume" translation="Ses Seviyesi" explanation="title" max="20"/>
     <string english="Change the volume of sound effects." translation="Ses seviyesini değiştir." explanation="" max="38*3"/>
-    <string english="Credits" translation="Jenerik" explanation="credits" max="13"/>
+    <string english="Credits" translation="Jenerik" explanation="credits" max="20"/>
     <string english="VVVVVV is a game by" translation="VVVVVV&apos;yi tasarlayan ve geliştiren:" explanation="credits" max="40"/>
     <string english="and features music by" translation="Müzikler:" explanation="credits" max="40"/>
     <string english="Roomnames are by" translation="Oda adları:" explanation="credits" max="40"/>
diff --git a/desktop_version/src/Render.cpp b/desktop_version/src/Render.cpp
index f430e82d..e7cf86d5 100644
--- a/desktop_version/src/Render.cpp
+++ b/desktop_version/src/Render.cpp
@@ -1766,7 +1766,16 @@ void gamecompleterender(void)
         font::print(0, 100, 480 + position, loc::gettext("Doctor Victoria"), tr, tg, tb);
     }
 
-    if (graphics.onscreen(520 + position)) font::print(PR_3X | PR_CEN, -1, 520 + position, loc::gettext("Credits"), tr, tg, tb);
+    if (graphics.onscreen(520 + position))
+    {
+        uint32_t flag = PR_3X;
+        const char* text = loc::gettext("Credits");
+        if (font::len(flag, text) > SCREEN_WIDTH_PIXELS)
+        {
+            flag = PR_2X;
+        }
+        font::print(flag | PR_CEN, -1, 520 + position, text, tr, tg, tb);
+    }
 
     if (graphics.onscreen(560 + position))
     {