From 78aa3ca71533338b8a583c00536e99a4eddd8b36 Mon Sep 17 00:00:00 2001 From: Misa Date: Fri, 16 Apr 2021 17:27:54 -0700 Subject: [PATCH] Switch SDL2 includes to be private There's no reason for these to be public, and putting it public is probably going to cause more harm than not. --- desktop_version/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop_version/CMakeLists.txt b/desktop_version/CMakeLists.txt index 0e9e5f4a..c40273e1 100644 --- a/desktop_version/CMakeLists.txt +++ b/desktop_version/CMakeLists.txt @@ -275,7 +275,7 @@ endif() # SDL2 Dependency (Detection pulled from FAudio) if(DEFINED SDL2_INCLUDE_DIRS AND DEFINED SDL2_LIBRARIES) message(STATUS "Using pre-defined SDL2 variables SDL2_INCLUDE_DIRS and SDL2_LIBRARIES") - target_include_directories(VVVVVV SYSTEM PUBLIC "$") + target_include_directories(VVVVVV SYSTEM PRIVATE "$") target_link_libraries(VVVVVV ${SDL2_LIBRARIES}) else() # Only try to autodetect if both SDL2 variables aren't explicitly set @@ -289,7 +289,7 @@ else() else() message(STATUS "No TARGET SDL2::SDL2, or SDL2, using variables") find_path(SDL2_MIXER_INCLUDE_DIRS NAMES SDL_mixer.h PATH_SUFFIXES SDL2) - target_include_directories(VVVVVV SYSTEM PUBLIC "$" ${SDL2_MIXER_INCLUDE_DIRS}) + target_include_directories(VVVVVV SYSTEM PRIVATE "$" ${SDL2_MIXER_INCLUDE_DIRS}) target_link_libraries(VVVVVV ${SDL2_LIBRARIES} SDL2_mixer) endif() endif()