From 623f4edc6e77a22ef9da7d6b62ef5bd63167befe Mon Sep 17 00:00:00 2001 From: Misa Date: Thu, 11 Feb 2021 16:26:12 -0800 Subject: [PATCH] Remove unnecessary static_casts in is_positive_num() The implicit conversion is completely okay. Adding an explicit cast here just creates noise for the reader to filter out. --- desktop_version/src/UtilityClass.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop_version/src/UtilityClass.cpp b/desktop_version/src/UtilityClass.cpp index 0331c2c2..9c9df3fd 100644 --- a/desktop_version/src/UtilityClass.cpp +++ b/desktop_version/src/UtilityClass.cpp @@ -290,14 +290,14 @@ bool is_positive_num(const std::string& str, bool hex) { if (hex) { - if (!VVV_isxdigit(static_cast(str[i]))) + if (!VVV_isxdigit(str[i])) { return false; } } else { - if (!SDL_isdigit(static_cast(str[i]))) + if (!SDL_isdigit(str[i])) { return false; }