From 40c6a01917dd185cfdda577578817a9b46c59342 Mon Sep 17 00:00:00 2001 From: Misa Date: Sat, 6 Mar 2021 15:30:22 -0800 Subject: [PATCH] Make saveFilePath not an std::string Since it only ever gets assigned from FILESYSTEM_getUserSaveDirectory(), and that function returns a C string, and the variable is only ever read from again, this doesn't need to be an std::string. --- desktop_version/src/Game.cpp | 8 ++++---- desktop_version/src/Game.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/desktop_version/src/Game.cpp b/desktop_version/src/Game.cpp index 02134fc7..6f4353eb 100644 --- a/desktop_version/src/Game.cpp +++ b/desktop_version/src/Game.cpp @@ -628,7 +628,7 @@ void Game::savecustomlevelstats(void) else { printf("Could Not Save level stats!\n"); - printf("Failed: %s%s\n", saveFilePath.c_str(), "levelstats.vvv"); + printf("Failed: %s%s\n", saveFilePath, "levelstats.vvv"); } } @@ -5758,7 +5758,7 @@ bool Game::savetele(void) if(!FILESYSTEM_saveTiXml2Document("saves/tsave.vvv", doc)) { printf("Could Not Save game!\n"); - printf("Failed: %s%s\n", saveFilePath.c_str(), "tsave.vvv"); + printf("Failed: %s%s\n", saveFilePath, "tsave.vvv"); return false; } printf("Game saved\n"); @@ -5785,7 +5785,7 @@ bool Game::savequick(void) if(!FILESYSTEM_saveTiXml2Document("saves/qsave.vvv", doc)) { printf("Could Not Save game!\n"); - printf("Failed: %s%s\n", saveFilePath.c_str(), "qsave.vvv"); + printf("Failed: %s%s\n", saveFilePath, "qsave.vvv"); return false; } printf("Game saved\n"); @@ -6033,7 +6033,7 @@ bool Game::customsavequick(std::string savfile) if(!FILESYSTEM_saveTiXml2Document(("saves/"+levelfile+".vvv").c_str(), doc)) { printf("Could Not Save game!\n"); - printf("Failed: %s%s%s\n", saveFilePath.c_str(), levelfile.c_str(), ".vvv"); + printf("Failed: %s%s%s\n", saveFilePath, levelfile.c_str(), ".vvv"); return false; } printf("Game saved\n"); diff --git a/desktop_version/src/Game.h b/desktop_version/src/Game.h index b3c1a3ad..b0421374 100644 --- a/desktop_version/src/Game.h +++ b/desktop_version/src/Game.h @@ -183,7 +183,7 @@ public: void initteleportermode(void); - std::string saveFilePath; + const char* saveFilePath; int door_left;