From 3fcab3a395e54ec4e6e44b7c0e54c5a04ec04ee9 Mon Sep 17 00:00:00 2001 From: Misa Date: Fri, 24 Sep 2021 16:02:22 -0700 Subject: [PATCH] Remove `splitseconds` lookup table and inline it There's really no reason for this simple multiplication plus division to be in a lookup table. The compiler will optimize it faster than putting it in a lookup table will, I'm sure. --- desktop_version/src/UtilityClass.cpp | 9 ++------- desktop_version/src/UtilityClass.h | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/desktop_version/src/UtilityClass.cpp b/desktop_version/src/UtilityClass.cpp index eb80417f..0b58b5ef 100644 --- a/desktop_version/src/UtilityClass.cpp +++ b/desktop_version/src/UtilityClass.cpp @@ -134,11 +134,6 @@ UtilityClass::UtilityClass(void) : glow(0), glowdir(0) { - for (size_t i = 0; i < SDL_arraysize(splitseconds); i++) - { - splitseconds[i] = (i * 100) / 30; - } - slowsine = 0; } @@ -194,14 +189,14 @@ std::string UtilityClass::timestring( int t ) if (temp < 60) //less than one minute { t = t % 30; - tempstring = String(temp) + ":" + twodigits(splitseconds[t]); + tempstring = String(temp) + ":" + twodigits(t * 100 / 30); } else { int temp2 = (temp - (temp % 60)) / 60; temp = temp % 60; t = t % 30; - tempstring = String(temp2) + ":" + twodigits(temp) + ":" + twodigits(splitseconds[t]); + tempstring = String(temp2) + ":" + twodigits(temp) + ":" + twodigits(t * 100 / 30); } return tempstring; } diff --git a/desktop_version/src/UtilityClass.h b/desktop_version/src/UtilityClass.h index 1f2a0f7b..45d6ecc8 100644 --- a/desktop_version/src/UtilityClass.h +++ b/desktop_version/src/UtilityClass.h @@ -114,7 +114,6 @@ public: int glow; int slowsine; int glowdir; - int splitseconds[30]; }; #ifndef HELP_DEFINITION