From 3728edc335632802a650b93aab12e820cbac68ff Mon Sep 17 00:00:00 2001 From: Misa Date: Tue, 13 Apr 2021 09:07:51 -0700 Subject: [PATCH] Remove time trial replay menu stack popping It turns out this entire chunk of code is simply unneeded (and is actively harmful) since when we're done with the time trial, quittomenu() gets called, and that removes the previous stack frame anyway. I'm guessing that I added this code, then added quittomenu(), then didn't consider how this code and quittomenu() would mix. But anyways, this bug is fixed. Fixes #714. --- desktop_version/src/Input.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/desktop_version/src/Input.cpp b/desktop_version/src/Input.cpp index 01ddc152..ef3c35ec 100644 --- a/desktop_version/src/Input.cpp +++ b/desktop_version/src/Input.cpp @@ -1580,15 +1580,6 @@ static void menuactionpress(void) map.nexttowercolour(); break; case 1: - //Ok but first quickly remove the last stack frame to prevent piling up timetrialcomplete stack frames - if (game.menustack.empty()) - { - puts("Error: menu stack is empty!"); - } - else - { - game.menustack.pop_back(); - } //duplicate the above based on given time trial level! if (game.timetriallevel == 0) //space station 1 {