From 36e91a9bb18c270476c1492d7c5f15a5c436a09d Mon Sep 17 00:00:00 2001 From: Misa Date: Sat, 6 Mar 2021 13:59:13 -0800 Subject: [PATCH] Fix MMMMMM and Flip Mode options ignoring save failure In #553, when Dav999 added error messages to settings menus if the game was unable to successfully save the changed settings, he seemed to have forgotten the PPPPPP/MMMMMM toggle option. However, I can fully blame him for only that miss. The Flip Mode options were using game.savemystats (which was removed in #591), so if he searched for all instances of game.savestats() (game.savestatsandsettings() was only added in #557), he would've missed the game.savemystats. Later, when I did #591, I didn't realize that I should've replaced the ones in the Flip Mode options with game.savestatsandsettings_menu(), so part of the blame does fall on me. Anyways, this is fixed now. --- desktop_version/src/Input.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop_version/src/Input.cpp b/desktop_version/src/Input.cpp index 976a49f5..aedc187e 100644 --- a/desktop_version/src/Input.cpp +++ b/desktop_version/src/Input.cpp @@ -176,7 +176,7 @@ static void updatebuttonmappings(int bind) static void toggleflipmode(void) { graphics.setflipmode = !graphics.setflipmode; - game.savestatsandsettings(); + game.savestatsandsettings_menu(); if (graphics.setflipmode) { music.playef(18); @@ -756,7 +756,7 @@ static void menuactionpress(void) { music.play(music.currentsong); } - game.savestatsandsettings(); + game.savestatsandsettings_menu(); } offset += mmmmmm_offset;