From 06cc5afe27df5a41efb8a06548d62cc8c4b5c280 Mon Sep 17 00:00:00 2001 From: Misa Date: Sun, 7 Feb 2021 13:17:22 -0800 Subject: [PATCH] Pass input of UtilityClass::GCString() by const reference This avoids an unnecessary copy of the input std::vector, since we don't need to modify it for anything. This cuts down on unnecessary memory operations. --- desktop_version/src/UtilityClass.cpp | 2 +- desktop_version/src/UtilityClass.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop_version/src/UtilityClass.cpp b/desktop_version/src/UtilityClass.cpp index c472583d..12c0d1f4 100644 --- a/desktop_version/src/UtilityClass.cpp +++ b/desktop_version/src/UtilityClass.cpp @@ -119,7 +119,7 @@ int UtilityClass::Int(const char* str, int fallback /*= 0*/) return (int) SDL_strtol(str, NULL, 0); } -std::string UtilityClass::GCString(std::vector buttons) +std::string UtilityClass::GCString(const std::vector& buttons) { std::string retval = ""; for (size_t i = 0; i < buttons.size(); i += 1) diff --git a/desktop_version/src/UtilityClass.h b/desktop_version/src/UtilityClass.h index 1f9c2c51..d93e5a54 100644 --- a/desktop_version/src/UtilityClass.h +++ b/desktop_version/src/UtilityClass.h @@ -39,7 +39,7 @@ public: static int Int(const char* str, int fallback = 0); - static std::string GCString(std::vector buttons); + static std::string GCString(const std::vector& buttons); std::string twodigits(int t);