Commit graph

588 commits

Author SHA1 Message Date
Michael Forney
eae31a532e Fix some bugs in mouse tracking logic
* Button number in X10 mode:

  I believe the button - 1 came from "C b is button - 1" from [0].
  However, above this section, it states

    "Normally, parameters (such as pointer poisition and button number)
     for all mouse tracking escape sequences generated by xterm encode
     numeric parameters in a single character as value+32. For example, !
     specifies the value 1."

  Also, from the description of SGR,

    "The encoded button value in this case does not add 32 since that
     was useful only in the X10 scheme for ensuring that the byte
     containing the button value is a printable code."

  This suggests that we should still add 32 to the button value when in
  MODE_MOUSEX10.

* No button release reporting in X10 mode:

    "X10 compatibility mode sends an escape sequence only on button press,
     encoding the location and the mouse button pressed."

* Fix MODE_MOUSEMOTION:

  Currently, motion reporting is skipped when oldbutton == 3
  (corresponding to no button being pressed). However, oldbutton is
  only set on a button press, which will never be 3.

[0]: http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
2013-09-13 19:49:25 +02:00
Roberto E. Vargas Caballero
bef599bb27 Add audible bell
\a is the character for bell, and st is only marking the window as urgent
if it is not active. This patch adds an audible bell which can be disable
with bellvolume variable.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-09-12 20:47:41 +02:00
Christoph Lohmann
210dda9570 Wide character support.
Thanks "Eon S. Jeon" <esjeon@hyunmu.am>!
2013-09-07 12:41:36 +02:00
Mark Edgar
4245ba0d12 Correctly initialize altscreen when defaultbg is not 0.
The alternate screen is not properly initialized when st starts. To see
this, set defaultbg in config.h to anything other than 0 (for example, swap
defaultfg and defaultbg), and run:

./st -e sh -c 'tput smcup; read'

You should see that the top-left 80x24 rectangle is black (or whatever
colorname[0] is), while the rest of the screen (if any) has the desired
colorname[defaultbg] color.

The attached patch fixes this by initializing term.c.attr in tnew() before
calling tresize(). It also removes the unnecessary xcalloc() calls, which
misled me on this bug hunt since it is really tclearregion() which
initializes term.lines and term.alt in tresize().
2013-09-04 18:33:02 +02:00
Eon S. Jeon
f3d438b101 Regarding commit 7e3cff3
Hello.

I reviewed and tested commit 7e3cff3, and made a patch that fixes some
problems in it.

1. There's a semicolon after an if statement, which is obviously a
typo.

2. The current way of calculating text position in "xdraws" yields
inconsistent results in some cases. This is due to the use of
"font->width", which varies. Instead, "xw.cw" has to be used as the
character width.

Sincerely,
Eon
2013-08-30 07:50:05 +02:00
Christoph Lohmann
8d21ced085 Correcting the bitmask value check. 2013-08-20 18:18:48 +02:00
Eon S. Jeon
347a45c352 Fix signess of tdefcolor
tdefcolor() returns -1 on error, while its return type is
unsigned long. At the same time, line 1724 and 1731 are checking the
positivity of its unsigned return value.
2013-08-06 08:32:11 +02:00
Alexander Sedov
22eeda56b7 Fixed memory leak in xsettitle(). 2013-08-05 11:45:53 +02:00
Michael Forney
86c03ddc82 Fix blink mode check
ATTR_BLINK is an attribute for a Glyph and will not be set in term.mode.
2013-08-05 11:45:52 +02:00
Eric Pruitt
7e3cff33ff Use character size scaling factors
The bounding boxes for characters can be scaled using "cwscale" and "chscale"
to scale the width and height respectively.
2013-08-05 11:44:18 +02:00
Roberto E. Vargas Caballero
aaee0e8b28 Reload colors in reset
Colors definition can be changed using a OSC sequence, so
we have to reload them if we want be sure all the colors
are the correct.

Could be desirable free the colors allocated due to rgb
colors and inverse colors (XftColorAllocValues in xdraws),
but it is impossible due we use the same structure for all
of them.
2013-07-20 23:25:46 +02:00
Roberto E. Vargas Caballero
8dde8cde41 Add RGB color definition
This patch uses the bit 24 in the color descriptor as an indicator
of RGB color, so we can take the values and generating the XftColour
directly in xdraws.
2013-07-20 23:25:38 +02:00
Eon S. Jeon
33ad83d492 Improved font caching
I made a patch that improves the performance of font caching mechanism.
This is based on a funny behaviour of FontConfig: it was handling
FcCharSet in a somewhat unexpected way.

So, we are currently adding "a character" to a new FcCharSet, and then
add it to a FcPattern. However, if we toss the FcPattern to FontConfig,
it loads the entire language(charset) that contains the character we
gave. That is, we don't always have to load a new font for each unknown
character. Instead, we can reused cached fonts, and this significantly
reduces the number of calls to extremely slow FontConfig matching
functions.

One more thing. I found that, in libXft, there's a function called
XftCharExists. XftCharIndex internally calls this function, and
does more stuffs if the character does exist. Since the returned index
is never used in st, we should call XftCharExists instead of
XftCharIndex. Please note that I already made this change in the patch.
2013-07-19 08:38:10 +02:00
Markus Teich
40e4d76d22 fix: whitespace 2013-07-04 09:58:14 +02:00
Alexander Sedov
fbc589d506 Remove long text being cropped/wrapped to standard 80x24 on launch.
To be more specific, now tty creation is delayed until X window is
actually mapped; last ConfigureNotify before mapping determines
initial tty size.
Please report problems if there are any.
2013-07-04 09:36:22 +02:00
Markus Teich
6fc471ccc6 fix: consistent usage of bitmask operations on unicode functions 2013-07-04 09:28:19 +02:00
Markus Teich
8b602a37a6 fix: do not need an extra variable for a single read 2013-07-04 09:26:18 +02:00
Roberto E. Vargas Caballero
6e1c7c8afc Fix match function bugs
There were two problems with match denfinition.

1) There was a forward declaration in the form:

	static inline bool match(uint, uint);

but later the function was defined as:

	inline bool
	match(uint mask, uint state) {

This causes that there were two different functions in the code, one local
and inline, and other inline but extern. All was working without problems
due to we were using -Os, and the compiler was using the extern definition
and it was no expanding the static declaration. If you removed the -Os flag,
then you got linker errors due it was no able to find the static definition
of the static declaration.

2) The mask checking was incorrect because we were doing the test:

	(state & mask) != state

and this test only was saying that at least all the enabled bits of state
were enabled also in mask, but no all the possible bits in mask. This was
the origin of the bug reported by Xavier Cartron, where he said it was
possible activated some shortcuts with some of the modifiers defined in the
config.h file.
2013-07-04 09:21:57 +02:00
Roberto E. Vargas Caballero
90c6f055b6 Remove unneded call to draw
draw is the function which update the Xwindow with the information st has,
and it is designed in a way that it must be called once in the main loop
(run function), and calling it in other places it is a waste of time.
2013-07-04 09:14:50 +02:00
Roberto E. Vargas Caballero
ebbac77d74 Fix selection clearing
The way st knows if there is a selection activated is checking if sel.ob.x
is equal to -1. In some parts of the code the way of disabling the selection
was only setting it to -1, but after it you can't be sure if the selection
is clearing from the terminal representation, because it is necessary mark
all the lines affected by the selection as dirty. Already there is a functon
which perform this task, selclear.
2013-07-04 09:14:50 +02:00
Christoph Lohmann
5d3318c0c7 Fixing title setting with the title argument. 2013-06-09 15:52:35 +02:00
Christoph Lohmann
369734c80c Adding xterm behaviour to setting the title.
Thanks Airwave!
2013-06-06 19:09:18 +02:00
Christoph Lohmann
7530694987 Adding true mouse motion support. 2013-06-01 14:37:30 +02:00
Christoph Lohmann
d743b93fda This is a shorter bit handling in MODE_MOUSE. 2013-06-01 13:17:20 +02:00
Christoph Lohmann
317b785921 Add some comments about the other mouse reporting modes. 2013-06-01 13:13:01 +02:00
Christoph Lohmann
405fd89ac1 Implementing mouse focus and all events. 2013-06-01 13:06:53 +02:00
Christoph Lohmann
8315dc4179 Fixing bad highlighting on first SNAP_WORD multiline select. 2013-06-01 12:23:55 +02:00
Christoph Lohmann
b5144100a5 Fixing the selection in a single line again.
Thanks p37sitdu@lavabit.com!
2013-05-26 16:10:22 +02:00
Christoph Lohmann
8f1bef0502 Fixing the selection scrolling and the selection naming.
Thanks p37sitdu@lavabit.com!
2013-05-26 13:07:26 +02:00
Christoph Lohmann
8f47c4a4de Lazy font unloading too. 2013-05-11 21:59:55 +02:00
Christoph Lohmann
62502a88e9 Lazy fontset loading.
Thanks Johannes Hofmann <Johannes.Hofmann@gmx.de>!
2013-05-11 08:54:26 +02:00
Christoph Lohmann
678eff6e18 Removing an old select() regression. 2013-05-06 19:50:14 +02:00
Christoph Lohmann
8e968739c3 Allow more complex delimiters for word selections.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
2013-05-04 19:04:20 +02:00
Christoph Lohmann
0c2b513d01 Expand the last line with '\n' in case of overselection.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
2013-05-04 19:00:32 +02:00
Christoph Lohmann
634c247fa7 Select to the end of row if end of line is reached.
Thanks Alexander Rezinsky <alexrez@gmail.com>!
2013-05-04 08:05:11 +02:00
Christoph Lohmann
5938fa9d32 Better comments for the snapping code. 2013-05-04 08:01:17 +02:00
Christoph Lohmann
8618386de9 More stable blinking. 2013-05-01 13:14:46 +02:00
Christoph Lohmann
911ba5674b Selection snapping is now considering wrapping.
Thanks Alexander Rezinsky <alexrez@gmail.com> for mentioning this!
2013-04-28 18:14:15 +02:00
Christoph Lohmann
a53017c8b4 Add a possibility to modify the string sent by mouse buttons.
Thanks Alexander Rezinsky <alexrez@gmail.com> for the suggestion!
2013-04-28 17:42:30 +02:00
Christoph Lohmann
a77b01176a Be more efficient in blinking. 2013-04-26 18:55:40 +02:00
Christoph Lohmann
1e09726518 Enable blinking in st. 2013-04-26 18:41:54 +02:00
Christoph Lohmann
1b2751f5c2 Fixing the selection handling to allow one char selection.
Thanks Alexander Sedov <alex0player@gmail.com> for suggesting the fix!
2013-04-25 06:28:11 +02:00
Christoph Lohmann
0851f2be2a Fixing the selection issue in altscreens. 2013-04-24 21:30:59 +02:00
Alexander Sedov
011c0f9e5b Removed redundant check in draw code.
We're now clearing empty areas with spaces, so there is no point to check
if character contains non-empty string.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-24 21:27:56 +02:00
Roberto E. Vargas Caballero
048c54fd5b Fix selecting clearing and BCE
The commit b78c5085f7 changed the st behaviour enabling BCE capability,
that means erase regions using background color. Problem comes when you
clear a region with a selection, because in this case the real mode of the
Glyph is not the value of term.line[y][x], due in drawregion we had enabled
the ATTR_REVERSE bit.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-23 20:36:30 +02:00
Christoph Lohmann
6b03bb769a Now clipping is more clear. 2013-04-23 19:37:28 +02:00
Christoph Lohmann
db6f796ecf Removing the overdrawing of some fonts. 2013-04-23 19:17:50 +02:00
Christoph Lohmann
2bd6afd1c9 Implementing 8 bit mode for meta. 2013-04-23 15:22:14 +02:00
Christoph Lohmann
b596d6ba3c Adding wrap handling in selection. 2013-04-21 13:01:16 +02:00
Alexander Sedov
872a7f18ea Added support for double/triple click+dragging.
Now double-click+dragging automatically snaps both ends to word boundaries
(unless on series of spaces), and triple-click selects whole lines.
As a side effect, snapping now occurs on button press, not button release
like it previously was, but I hope that won't be inconvenient for anyone.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-20 15:54:19 +02:00
Alexander Sedov
e5ff746430 Selection now handles empty lines less counter-intuitively.
Now, when you are selecting a region, you will get all empty lines that happen
to be in it, including trailing ones. Last line terminator is omitted as it previously
was, though.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-18 16:51:52 +02:00
Christoph Lohmann
da182612b7 Removing trailing whitespace. 2013-04-18 06:51:18 +02:00
Alexander Sedov
b7e6a5c825 Got rid of redundant Glyph state.
Now, newly allocated Glyphs are set to spaces and current cursor colors
with tclearregion() routine.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-18 06:48:06 +02:00
Christoph Lohmann
3ae0299064 Removing unneeded comments. 2013-04-18 06:41:54 +02:00
Alexander Sedov
fed9968ba5 Got rid of code duplication in tnew() and tresize().
Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-18 06:39:43 +02:00
Alexander Sedov
0ca0dd8b11 Strip trailing spaces from lines when copying selection.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-04-14 21:32:53 +02:00
Christoph Lohmann
c371fe58a3 Enable BCE everywhere. 2013-04-14 18:30:10 +02:00
Christoph Lohmann
44db38a5f8 Fix the geometry handling. 2013-04-13 15:24:26 +02:00
Christoph Lohmann
de4cd2f6af Resize now uses xclear(). 2013-04-13 09:49:11 +02:00
Christoph Lohmann
1e7816c202 Drawing a more visible rectangle as cursor on unfocus.
To have a more visible cursor on unfocused windows this patch makes st draw a
rectangle around the terminal cell.

Thanks Mark Hills <mark@xwax.org> for the suggestion!
2013-04-13 09:44:00 +02:00
Christoph Lohmann
5dc48af29e Patching while not really woken up. 2013-04-13 08:51:30 +02:00
Christoph Lohmann
5984657c00 Minor naming issue fixed. 2013-04-13 08:50:38 +02:00
Christoph Lohmann
4018b2c507 Making the copy and pasting consistent.
The copying and pasting in the terminald and GUI world is flawed. Due to the
discussion on the mailinglist it seems that sending '\n' is what GUIs expect
and '\r' what terminal applications want. St now implements that behaviour.
2013-04-13 08:48:17 +02:00
Christoph Lohmann
684cf55a0d Make st work with a plain -e command. 2013-04-10 17:48:32 +02:00
Christoph Lohmann
b1813b14d9 Adopting arg.h with more flexible cmd handling. 2013-04-03 21:00:38 +02:00
Christoph Lohmann
580c8bbd46 Add an option to disable alternative screens. 2013-04-03 20:42:27 +02:00
Christoph Lohmann
7e7760c2ed Add the possibility to have default highlight colors.
Thanks to stargrave@stargrave.org for the suggestion!
2013-03-29 19:01:24 +01:00
Christoph Lohmann
a1e3b94b37 Removing an undefined case. just do regular selections. 2013-03-29 18:39:01 +01:00
Christoph Lohmann
4b17dddb10 Making rectangular selection work again.
People sending me patches against strange revisions and basing on their own
revisions make me having to reapply them. Then such errors appear.

Thanks Alexander Sedov <alex0player@gmail.com> for noticing this.
2013-03-20 21:19:28 +01:00
Christoph Lohmann
55adf0aad1 Pange seems to use ascent + descent instead of height.
Thanks Bobby Powers <bobbypowers@gmail.com> for noticing this!
2013-03-10 21:16:51 +01:00
Christoph Lohmann
c6b89f23e7 Using strsep and fixing null termination in csiparse.
Thanks for the hint from Alexander Sedov <alex0player@gmail.com>!
2013-02-26 21:43:40 +01:00
Christoph Lohmann
1c1621da69 Changing the way how paste is handled, just for the nano people. 2013-02-26 19:08:51 +01:00
Christoph Lohmann
1aa26b4ecd Fixing a bug while parsing empty arguments in csiparse. 2013-02-26 19:07:23 +01:00
Christoph Lohmann
7d32471eff Fixing bugs in the strtol and strtok_r replacements.
Thanks "Roberto E. Vargas Caballero" <k0ga@shike2.com> for the comments!
2013-02-26 18:19:44 +01:00
Christoph Lohmann
7cb0d95509 Using strtok_r for the string parsing. 2013-02-25 13:36:40 +01:00
Christoph Lohmann
37863356b0 Using strtol with overflow checking. 2013-02-25 13:23:56 +01:00
Christoph Lohmann
be7c6d7fb0 Add insert for the primary clipboard to MOD + Shift + Ins.
Thanks Mantas Mikulėnas <grawity@gmail.com> for the patch!
2013-02-23 21:50:13 +01:00
Christoph Lohmann
e40d8da194 Removing dbe and introducing umlauts to titles.
Thanks Alexander Sedov <alex0player@gmail.com> for the title patch!
2013-02-23 21:44:06 +01:00
Christoph Lohmann
efaf1c2a94 Add umlaut support for title change.
Thanks Alexander Sedov <alex0player@gmail.com>!
2013-02-23 21:20:21 +01:00
Christoph Lohmann
1b6c6535c1 Replace parse_int with atoi(). 2013-02-23 21:17:25 +01:00
Alexander Sedov
800800a3bb Added basic xterm-ish palette swap support.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-02-19 19:12:42 +01:00
Christoph Lohmann
3865e9eaaf Implement rectangular mouse selection.
Thanks Alexander Sedov <alex0player@gmail.com>!
2013-02-19 19:08:41 +01:00
joe9
e5295629cd ensure that the italic font has the same weight as the normal font
The specified font[] pattern need not have a medium weight. It could be
specified as a number too or have a different weight other than medium.

Signed-off-by: Christoph Lohmann <20h@r-36.net>
2013-02-19 16:09:05 +01:00
Christoph Lohmann
0e738c3d72 Style inquisition. 2013-02-19 16:04:54 +01:00
Christoph Lohmann
7f297e297c Fixing the reverse mode of st colors.
Thanks Alexander Sedov <alex0player@gmail.com> for finding this!
2013-02-19 15:51:25 +01:00
Christoph Lohmann
f4a6c20f46 Adding a way to ignore bits in the state. 2013-02-16 13:57:12 +01:00
Christoph Lohmann
e0ec2cf984 Style inquisition. 2013-02-15 19:36:20 +01:00
Christoph Lohmann
086cd61511 Doing it like the new run() was proposed. 2013-02-15 19:30:43 +01:00
Christoph Lohmann
95033753be Adding a more efficient drawing code.
Thanks Mihail Zenkov <mihail.zenkov@gmail.com> for giving the hint!
2013-02-15 19:10:22 +01:00
Christoph Lohmann
b7261c84aa Tmux wants this to be mutually exclusive.
Thanks Egmont Koblinger <egmont@gmail.com> for noticing this!
2013-02-15 17:45:38 +01:00
Christoph Lohmann
05a1ff03e9 Adding mor explict font patterns. 2013-02-13 21:35:27 +01:00
Christoph Lohmann
eeffbe11ab Making st not activate the cursor in case of Mod + k in dwm.
Thanks Jens Nyberg <jens.nyberg@gmail.com>!
2013-02-11 22:20:16 +01:00
Christoph Lohmann
8a9475a0dd Setting the surrounding border to defaultbg.
Thanks Stephen Caraher <moskvax@gmail.com>!
2013-02-10 16:36:03 +01:00
Christoph Lohmann
ce3efa9e9b Removing some debug messages. 2013-02-08 20:24:26 +01:00
Christoph Lohmann
efd04ccad6 Fixing the menus in mc. 2013-01-27 17:48:01 +01:00
Christoph Lohmann
26c101b706 Fixing the black remaining lines in mc and dialog.
This also applies some style fixes and handles some old blink codes.
2013-01-27 13:26:06 +01:00
Christoph Lohmann
384fabdb5b Adding extended mouse reporting in st.
Thanks Egmont Koblinger <egmont@gmail.com>!
2013-01-26 15:13:56 +01:00
Christoph Lohmann
deb720af7f Removing the debug messages again. 2013-01-20 17:13:48 +01:00
Christoph Lohmann
57f39defaf Fixing the clipboard copying to st itself. 2013-01-20 17:12:41 +01:00
Christoph Lohmann
3036051fb1 St is in 2013 now. 2013-01-20 15:12:45 +01:00
Christoph Lohmann
b78c5085f7 Implementing Back Color Erase (BCE). 2013-01-20 14:54:35 +01:00
Christoph Lohmann
b4b513c791 Make line drawing work again. 2013-01-19 18:38:28 +01:00
Christoph Lohmann
15c2bff9fa Yes, xft should be on the buffer. Thanks Mihail Zenkov. 2013-01-19 15:49:34 +01:00
Christoph Lohmann
c7b033b8f0 Trying out the double buffering without dbe. 2013-01-19 15:00:16 +01:00
Christoph Lohmann
0e232a4115 Dbe is not required anymore. 2013-01-19 09:13:52 +01:00
Christoph Lohmann
ed90afb743 The title can now be set with UTF-8 characters.
Thanks Mihail Zenkov <mihail.zenkov@gmail.com>!
2013-01-18 19:11:25 +01:00
Christoph Lohmann
1827e0643f Standout mode has changed. Thanks p37sitdu@lavabit.com! 2013-01-08 20:36:49 +01:00
Christoph Lohmann
b3326ab63b A different double buffering strategy so the background is default set. 2013-01-08 20:09:33 +01:00
Christoph Lohmann
b233007e0f Damn, my fault. The cache should have at least some entries. 2013-01-05 20:56:58 +01:00
Christoph Lohmann
c772a6e571 Applying the changes to the docs; by Peter Hartman. 2013-01-05 20:30:25 +01:00
Christoph Lohmann
4e14a4a97f A fix for the XopenIM() errors. 2013-01-01 13:15:43 +01:00
Christoph Lohmann
c99db5b017 Increasing font cache for speeding up UTF8 demos. 2012-12-30 17:35:41 +01:00
Christoph Lohmann
44e1b79abf Removing the warning about extents. 2012-12-30 17:35:15 +01:00
Christoph Lohmann
08e06ef079 Fixing the font unloading in case of zoom. 2012-12-29 16:24:33 +01:00
Christoph Lohmann
addc848345 Speeding up the drawing, then all characters are known. 2012-12-29 15:03:03 +01:00
Christoph Lohmann
9c44229c62 Adding fallback support to st. 2012-12-28 23:52:04 +01:00
Christoph Lohmann
082bab29f3 Fixing a compile error. 2012-12-22 19:50:02 +01:00
Christoph Lohmann
ac4c6da4ef Fixing a off-by-one error in the penultimate row drawing. 2012-12-22 13:39:27 +01:00
Christoph Lohmann
4d37763ee7 Fixing a precedence problem. Thanks tridactyla! 2012-12-18 13:00:00 +01:00
Christoph Lohmann
fc2b366968 Checking for the lower X11 special keys too. Thanks Benjamin R. Haskell! 2012-12-13 20:57:15 +01:00
Christoph Lohmann
3c6ec1995d Adding error checks for XCreateIC and XOpenIM. 2012-12-11 08:32:08 +01:00
Christoph Lohmann
2696f81875 Be careful about mar77i's patches. 2012-12-10 23:02:58 +01:00
Christoph Lohmann
78215c8ee0 Fixing the nasty selection bug. Thanks p37sitdu@lavabit.com! 2012-12-10 20:45:46 +01:00
Christoph Lohmann
373a8f5628 The style inquisition was here. 2012-11-25 09:23:34 +01:00
Roberto E. Vargas Caballero
172f65436c Add key for toogling numlock handling
Keypad will generate keycodes when keypad application mode is enabled. It
can cause problems with some programs like vi, which operates in such
mode.

This patch change by default don't generate the keycodes never, but this
behaviour can be changed using the combination Alt + NumLock.
---
 config.def.h |   34 ++++++++++++++++++----------------
 st.c         |   17 +++++++++++++++--
 2 files changed, 33 insertions(+), 18 deletions(-)
2012-11-25 09:23:02 +01:00
Christoph Lohmann
b26df1d0d3 Fixing the calculation of the base tty pixel size. 2012-11-21 20:38:15 +01:00
Christoph Lohmann
440a19a662 Getbuttoninfo is always used the same and just a helper function. Shrinking it
a bit. Thanks nsz!
2012-11-15 21:42:58 +01:00
Roberto E. Vargas Caballero
6312f76ca4 Fix speech error in comment
---
 st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
2012-11-15 20:57:37 +01:00
Roberto E. Vargas Caballero
0df350cd0b Remove unused fields in cursor_movement
---
 st.c |    4 ----
 1 file changed, 4 deletions(-)
2012-11-15 20:57:33 +01:00
Christoph Lohmann
1cea02be8d Removing my debug fprintf(). 2012-11-15 20:25:16 +01:00
Christoph Lohmann
2b6521f5d2 Optimizing the key lookup to the X11 function key. It is still possible to
remap other keys.
2012-11-15 20:19:35 +01:00
Roberto E. Vargas Caballero
90e1427632 Fix Shift + Insert shortcut
This patch apply the same code for shortcuts that it is used now for defined
keys. So it is possible use now XK_NO_MOD and XK_ANY_MOD for defining shortcuts.
---
 st.c |   35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)
2012-11-15 19:01:16 +01:00
Christoph Lohmann
d5640c7729 Fixing the return and keypad enter sent characters. Terminals produce \r. And
some minor style changes.
2012-11-15 16:26:50 +01:00
Christoph Lohmann
801ea034b6 Import the patch of Eckehard Berns to add insert mode. Thanks! 2012-11-15 16:21:23 +01:00
Roberto E. Vargas Caballero
88bb76c1bc Fix XK_NO_MOD and XK_ANY_MOD behavior
XK_NO_MOD match a key without modifiers and XK_ANY_MOD match a key does not
matter what modifiers are pressed to. Like they are mask the best value for
XK_ANY_MOD is all the bits to 1, so the and with any state will be equal to
the state. This also imply that is necessary check the case for XK_NO_MOD
(no modifiers at all) with some modifier in state, and the inverse
(some mask different to XK_ANY_MOD or XK_NO_MOD and no modifiers in state).
---
 st.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
2012-11-15 15:36:13 +01:00
Roberto E. Vargas Caballero
16ccf344de Fix tab key
When Shift + Tab is pressed X server send the event XK_ISO_Left_Tab with
ShiftMask, so this is the entry we need in config.def.h

This patch also revert the previous patch for this issue because it breaks
the keyboard.
---
 config.def.h |    2 +-
 st.c         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
2012-11-14 11:14:29 +01:00
Christoph Lohmann
461aac159c Fixing the tab key, when no mask is wanted. 2012-11-14 06:37:24 +01:00
Christoph Lohmann
7474a2fc37 The style inquisition was here again. 2012-11-13 20:13:39 +01:00
Roberto E. Vargas Caballero
ea782bfc5d Remove hardcoded keys form kpress
Some keys were in the Key array while others were hardcoded in
kpress().This cause some problems with some keys which can generate more of
one string based in the configuration of the terminal.
---
 config.def.h |   70 ++++++++++++++++++++++++++++++++++++++++-----------------
 st.c         |   71 +++++++++++++++++++++++++---------------------------------
 2 files changed, 79 insertions(+), 62 deletions(-)
2012-11-13 20:04:45 +01:00
Roberto E. Vargas Caballero
93f31166bf Move Shift + Insert to shortcut
Shift + Insert is used like a hot key for paste the selection, so it is more
logical move it to shortcut array instead of having special code for it.
---
 config.def.h |    1 +
 st.c         |   13 +++----------
 2 files changed, 4 insertions(+), 10 deletions(-)
2012-11-13 20:04:39 +01:00
Roberto E. Vargas Caballero
69ee3ba3a7 Fix keypad mode and cursor mode
Keypad mode is used for detecting when keys in the auxiliary keypad are
pressed, while cursor mode is used for detecting when a cursor is pressed,
but they are different modes.

St was mixing both modes and DECPAM and DECPNM modified the cursor mode, and
this was incorrect.
---
 st.c    |    5 +++--
 st.info |    4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)
2012-11-13 20:04:34 +01:00
Roberto E. Vargas Caballero
73177ba366 Add SRM sequence
This sequence enable/disable the local echo.
---
 st.c |   76 ++++++++++++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 56 insertions(+), 20 deletions(-)
2012-11-13 20:04:26 +01:00
Christoph Lohmann
ace789a79f Gc is not used anymore. 2012-11-11 19:46:34 +01:00
Christoph Lohmann
c4a9ccec19 Removing some xft naming cruft. 2012-11-11 19:38:41 +01:00
Christoph Lohmann
5d5a7c627a Moving the alt declaration to the beginning of the function. 2012-11-08 17:22:48 +01:00
Roberto E. Vargas Caballero
8665905216 Move unsupported sequences to ignored.
These sequences will be never implemented and in this moment they are
generating a lot of noise.
---
 st.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
2012-11-08 17:22:04 +01:00
Roberto E. Vargas Caballero
27468403cc Ignore DECARM sequence
DECARM modify the auto repeat settings in the keyboard, and since we can not
modify this setting in the Xserver the best solution is only ignore it.
---
 st.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
2012-11-08 17:21:41 +01:00
Roberto E. Vargas Caballero
d5b80e05e8 Fix VPR sequence
VPR stands for Move cursor down a number of rows, and the code was moving
the cursor up instead of moving it down.
---
 st.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
2012-11-08 17:21:24 +01:00
Roberto E. Vargas Caballero
5260a9ea22 Add DECOM sequence
DECOM sequence allows to the user defines a new home position. The home
position is used as base for all the movement commands except HVP and
VPA. It is important notice than DECSLM moves cursor to absolute position
0,0.
---
 st.c |   33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)
2012-11-08 17:21:10 +01:00
Roberto E. Vargas Caballero
ee3e0a9fd0 Save cursor position in terminal reset
After terminal reset saved terminal position is reset to 0, allowing know
where cursor will go in next restore cursor operation.
---
 st.c |    2 ++
 1 file changed, 2 insertions(+)
2012-11-08 17:20:15 +01:00
Roberto E. Vargas Caballero
ba9d0365ac Clarify some or exclusive expressions
Since relational expresions are always evaluated to 0 or 1, we can use
bitwise xor operator instead of using more complex boolean expressions.
---
 st.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
2012-11-08 17:17:26 +01:00
Roberto E. Vargas Caballero
950ff21e17 Fix bug restoring cursor position
Sequences like DECSC, DECRC, ESC [?1047l or ESC [?1047h save and restore
cursor attributes, than taken from vt100 manual are:

       Save Cursor (DECSC) ESC   7
       ===========================
       Saves the following in terminal memory.

      - cursor position
      - graphic rendition
      - character set shift state
      - state of wrap flag
      - state of origin mode

      Restore Cursor (DECRC) ESC 8
      ===========================
      Restores the states described for (DECSC) above. If none of these
      characteristics were saved, the cursor moves to home position; origin
      mode is reset; no character attributes are assigned; and the default
      character set mapping is established.

This implies that hide attribute of the cursor should not be saved/restored
in these sequences. The best way to fix this problem is moving hide
attribute into the terminal mode, instead of having it in the cursor state.
---
 st.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
2012-11-08 17:15:26 +01:00
Christoph Lohmann
5d39afc902 Adding scrollwheel support. Thanks Brandon Invergo! 2012-11-06 23:44:37 +01:00
Christoph Lohmann
0fbe1559c8 Fixing meta+return. Thanks Szabolcs Nagy! 2012-11-04 00:04:56 +01:00
Christoph Lohmann
86261187ab Removing the debugging for the last fix too. 2012-11-03 14:05:45 +01:00
Christoph Lohmann
9888c5064b Fixing a resize bug, if a smaller amount than the lineheight is resized.
Thanks c00kiemon5ter!
2012-11-03 14:05:15 +01:00
Christoph Lohmann
f8db65439a Fixing bold fonts in reverse mode. 2012-11-03 13:43:20 +01:00
Christoph Lohmann
76a8e5f72b Now italic and bold works. 2012-11-03 08:35:32 +01:00
Christoph Lohmann
abe85c0e99 Fixing an out-of-bound bug in the selection code. Thanks Szabolczs Nagy! 2012-11-03 03:24:22 +01:00
Christoph Lohmann
091ae143ce Fixing the italic-bold font check. Thanks nsz. 2012-11-02 23:19:56 +01:00
Christoph Lohmann
c631e9bb91 Make it possible to use the corefont font description too. It is not very
useful, but easy to implement.
2012-11-02 20:07:11 +01:00
Christoph Lohmann
393825f9f8 Moving to the dwm config.h variable usage. 2012-11-02 19:56:02 +01:00
Christoph Lohmann
c5dd7fb377 Applying the patch of the little girl <yui@blekksprut.net> to make cjk input
possible. Thanks!
2012-10-28 13:37:11 +01:00
Christoph Lohmann
b56a0da283 Applying the tab expansion patch from koga. 2012-10-28 13:35:00 +01:00
Christoph Lohmann
71b09ec4f1 Adding a more flexible fontstring handling, shortcuts and a zoom function. 2012-10-28 13:25:53 +01:00
Christoph Lohmann
6d4e525ed9 Applying the patch of Roberto Caballero to set WINDOWID and all the pwuid()
variables. Thanks! xinit() and ttynew() had to be switched in their
call-appearance. Otherwise xw.win is not set.
2012-10-28 06:54:08 +01:00
Christoph Lohmann
35421371ca Applying the patch of Rafa Garcia Gallega <rafael.garcia.gallego@gmail.com> to
not emulate the vt100 behaviour of selecting all whitespaces. Thanks!
2012-10-28 06:32:54 +01:00
Roberto E. Vargas Caballero
ee3fbeb6c8 Add error control to iofile
write can write less bytes than we request, so it is necessary check the
return value, in case of error print a message and don't continnue writing
in the file.
---
 st.c |   39 ++++++++++++++++++++++++++++++---------
 1 file changed, 30 insertions(+), 9 deletions(-)
2012-10-28 06:27:42 +01:00
Christoph Lohmann
2e38ab7afd Well, I was confused. Damn state exams. Instead of discussing this shit I
should really learn opthalmology instead. :O
2012-10-09 19:40:37 +02:00
Christoph Lohmann
eb6713acf1 If there is really someone without SHELL set, help him/her. 2012-10-09 19:33:26 +02:00
Roberto E. Vargas Caballero
9e813947cf Add DEC alignment test
This sequence was used by DEC personal in to for verifying the screen adjust
of terminals. It is the unique test sequence implemented by all the
emulators, and I think it is because they want be conforms with vttest which
uses this sequence in some tests.
---
 st.c |   31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)
2012-10-07 11:06:17 +02:00
Roberto E. Vargas Caballero
b7a7f171ef Avoid initialization of vt100_0 in each call to tsetchar
If vt100_0 is a automatic variable then it is initializated in each call to
tsetchar, but if the variable is static it is initializated only in compile
time.
---
 st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
2012-10-07 11:06:08 +02:00
Roberto E. Vargas Caballero
25f47cb83a Fix Identification sequences
Do not send NUL character in the identification (use (sizeof(VT102ID) - 1),
and finish  the sequence once you execute it.
---
 st.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
2012-10-07 11:06:00 +02:00
Roberto E. Vargas Caballero
ffeeb678c5 Add DA and DECID sequences
These sequences are used by the host in order to can detect which kind of
terminal is connected. St will answer like a vt102 terminal with this patch.
---
 st.c |    9 +++++++++
 1 file changed, 9 insertions(+)
2012-10-06 21:19:56 +02:00
Christoph Lohmann
bffa6e5cc6 Fixing a typo. 2012-10-06 21:02:25 +02:00
Christoph Lohmann
b16b5d77d3 Fixing a off-by-one error in the new border clearing code. 2012-10-06 20:52:22 +02:00
Roberto E. Vargas Caballero
2bd0c23fa7 Print control codes only in graphic mode
Non handled codes must be ignored, except in graphic mode. Also STR
sequences have higher priority than control codes, so they must be handled
before of them.
---
 st.c |  160 ++++++++++++++++++++++++++++++++++++------------------------------
 1 file changed, 87 insertions(+), 73 deletions(-)
2012-10-06 19:15:30 +02:00
Roberto E. Vargas Caballero
034dc71fb8 Add SI and SO control codes
SI and SO allows change the G0 and G1 selection. This implementation is not
full vt100 compatible, but it is complatible with linux virtual terminal
implementation. For full vt100 compatibility we need remake a lot of stuff
relate to the different charmaps.
---
 st.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
2012-10-06 19:13:36 +02:00
Roberto E. Vargas Caballero
fbfa1f83eb Add SUB and CAN control codes
These control codes reset any escape sequence already initialised.
---
 st.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
2012-10-06 19:13:08 +02:00
Roberto E. Vargas Caballero
ac8f05c45a Add documentation to control codes
Add the documentation from the vt100 manual programmer:

Control 	Octal      Action Taken
Character	Code
-------------------------------------------
NUL		000	Ignored on input (not stored in input buffer;
			see full duplex protocol).
ENQ		005	Transmit answerback message.
BEL		007	Sound bell tone from keyboard.
BS		010	Move the cursor to the left one character position,
			unless it is at the left margin,
			in which case no action occurs.
HT		011	Move the cursor to the next tab stop,
			or to the right margin if no further tab stops
			are present on the line.
LF		012	This code causes a line feed or
			a new line operation. (See new line mode).
VT		013	Interpreted as LF.
FF		014	Interpreted as LF.
CR		015	Move cursor to the left margin on the current line.
SO		016	Invoke G1 character set, as designated by SCS
			control sequence.
SI		017	Select G0 character set, as selected by ESC ( sequence.
XON		021	Causes terminal to resume transmission.
XOFF		023	Causes terminal to stop transmitted all codes
			except XOFF and XON.
CAN		030	If sent during a control sequence, the sequence is
			immediately terminated and not executed. It also causes
			the error character to be displayed.
SUB		032	Interpreted as CAN.
ESC		033	Invokes a control sequence.
DEL		177	Ignored on input (not stored in input buffer).
--------------------------------------------
---
 st.c |   28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)
2012-10-06 19:12:46 +02:00
Christoph Lohmann
02f3b37a2d Forgot to remove the xclearborders() definition from the last commit. 2012-10-06 13:45:14 +02:00
Christoph Lohmann
0cc7ee5e73 Removing the xclearborders() hack. St now cleans up the parts of the border,
if something needs to be drawn close to it.
2012-10-06 13:43:01 +02:00
Christoph Lohmann
4eddf19fdc The style inquisition was here. Yes, making it a unified style. The last
infidels will be squashed too!
2012-10-06 09:58:45 +02:00
Christoph Lohmann
7efa4514d1 Adding the patch of David Dufberg Töttrup to implement WM_DELETE_WINDOW. Thank you! 2012-10-05 22:59:08 +02:00
Christoph Lohmann
bf6cf05ba5 Fixing the brightening on bold. For the 256 colors and greyscale I assumed a
reasonable solution.
2012-10-05 22:51:08 +02:00
Christoph Lohmann
0b489c4a6a When the drawing behaviour was changed underline was not corrected.
Thanks to Peter A. Shevtsov!
2012-10-05 09:38:10 +02:00
Christoph Lohmann
2752018e27 This adds the fontcache dependency to try something out. Additionally the
invert mode now works as expected. In the config.def.h autohint is set to
false, so the fonts are drawn correctly, without any overlapping.
2012-10-04 22:59:45 +02:00
Christoph Lohmann
0d88f1ef75 Thanks to c00kiemon5ter. Not changing bold to bright colors seems to be the
right choice.
2012-10-02 12:48:55 +02:00
Christoph Lohmann
5dfd5df4fe This changes -f to be the parameter for the font. Now -f is -o.
The parameters were reordered according to the alphabet too.
2012-09-30 20:23:10 +02:00
Christoph Lohmann
9cae1eb0de Remove the cruft of the user to have to define the different font styles. 2012-09-30 20:10:58 +02:00
Christoph Lohmann
ed5b8700a6 We need all the colors to be available, so die() on some not available.
This is a new opportunity to see if X11 somewhen handled colors in a strange
way.
2012-09-29 11:23:34 +02:00
Christoph Lohmann
d7b1e31eec All xcolors are not Xft colors and the clearing of the borders has been
optimized. There is a speedup when resizing windows.
2012-09-29 11:17:16 +02:00
Christoph Lohmann
29b209f5f5 Vt escape sequences allow escape sequences in escape sequences and escape
sequences, so we have to support escape sequences in escape sequences that
escape sequences in escape sequences – setting a title won't notify you
anymore.
2012-09-27 19:28:44 +02:00
Roberto E. Vargas Caballero
3af49e34f6 Allow control characters inside escape sequences
Taken from vt100 manual programmer:

	Control characters (codes \0 to \37 inclusive) are specifically
	excluded from the control sequence syntax, but may be embedded
	within a control sequence. Embedded control characters are executed
	as soon as they are encountered by the VT100. The processing of the
	control sequence then continues with the next character received.
---
 st.c |   68 +++++++++++++++++++++++++++++++++---------------------------------
 1 file changed, 34 insertions(+), 34 deletions(-)
2012-09-26 20:55:18 +02:00
Roberto E. Vargas Caballero
a7d7e29300 Ignore all control characters not handled
Taken from vt100 programmer manual:

	Control characters have values of \000 - \037, and \177. The control
	characters recognized by the VT100 are shown in Table 3-10. All
	other control codes cause no action to be taken.

We have to take attention when we are using alternate charset, because in
this cases they are not used as control characters.
---
 st.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
2012-09-26 20:53:46 +02:00
Christoph Lohmann
3a095984b0 Implementing line drawing right. 2012-09-26 20:21:08 +02:00
Christoph Lohmann
c3b0e2202b A reset should reset the line drawing too. 2012-09-25 21:39:25 +02:00
Christoph Lohmann
980c5956ed Enabling enacs and adding compatibility to xterm and urxvt for alternative
charsets.
2012-09-25 21:17:43 +02:00
Roberto E. Vargas Caballero
eb360e5fd1 Fix bug in tputc writing to io file
If -f options is enabled then tputc() writes all the data to a file. Actual
code assumes that all the strings in 'c' parameters have always 1 byte
length, but this is not always true, because due to utf-8 encoding some
characters can have a diferent length. So it is necessary pass string length
to tputc in order it can call to write() correctly.
---
 st.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
2012-09-25 21:04:35 +02:00
Christoph Lohmann
055a4f6d2c The xinit() call needs to be behind all the tty init, otherwise all the
allocated structures are wrong. The xclear() is now done on purpose. Please
keep X11 calls out of the way of pure tty-related calls.
2012-09-24 11:04:26 +02:00