diff --git a/servant-js/examples/www/angular/index.html b/servant-js/examples/www/angular/index.html index 81ce491a..46ecf5ae 100644 --- a/servant-js/examples/www/angular/index.html +++ b/servant-js/examples/www/angular/index.html @@ -21,11 +21,11 @@ counterApp.controller('CounterCtrl', ['$scope', '$http', '$interval', function ( var publishCounter = function (response) { $scope.counter = response.value; }; $scope.getCounter = function() { - getcounter($http) + getCounter($http) .success(publishCounter); } $scope.incCounter = function() { - postcounter($http) + postCounter($http) .success(publishCounter); } diff --git a/servant-js/examples/www/jquery/index.html b/servant-js/examples/www/jquery/index.html index 48c7d652..eb1a5b6c 100644 --- a/servant-js/examples/www/jquery/index.html +++ b/servant-js/examples/www/jquery/index.html @@ -17,11 +17,11 @@ diff --git a/servant-js/examples/www/vanilla/index.html b/servant-js/examples/www/vanilla/index.html index 245172ab..9f663ae8 100644 --- a/servant-js/examples/www/vanilla/index.html +++ b/servant-js/examples/www/vanilla/index.html @@ -16,11 +16,11 @@ diff --git a/servant-js/src/Servant/JS.hs b/servant-js/src/Servant/JS.hs index 8dfb1e37..23835d21 100644 --- a/servant-js/src/Servant/JS.hs +++ b/servant-js/src/Servant/JS.hs @@ -80,9 +80,9 @@ module Servant.JS , defCommonGeneratorOptions , -- * Function renamers - concatRenamer - , snakeCaseRenamer - , camelCaseRenamer + concatCase + , snakeCase + , camelCase , -- * Vanilla Javascript code generation vanillaJS diff --git a/servant-js/src/Servant/JS/Angular.hs b/servant-js/src/Servant/JS/Angular.hs index 68ff0a27..2b0066aa 100644 --- a/servant-js/src/Servant/JS/Angular.hs +++ b/servant-js/src/Servant/JS/Angular.hs @@ -123,7 +123,7 @@ generateAngularJSWith ngOptions opts req = "\n" <> fsep = if hasService then ":" else " =" - fname = namespace <> (functionRenamer opts $ req ^. funcName) + fname = namespace <> (functionNameBuilder opts $ req ^. funcName) method = req ^. reqMethod url = if url' == "'" then "'/'" else url' diff --git a/servant-js/src/Servant/JS/Internal.hs b/servant-js/src/Servant/JS/Internal.hs index 2a3eee88..a101f235 100644 --- a/servant-js/src/Servant/JS/Internal.hs +++ b/servant-js/src/Servant/JS/Internal.hs @@ -29,7 +29,7 @@ import Servant.API -- customize the output data CommonGeneratorOptions = CommonGeneratorOptions { - functionRenamer :: FunctionName -> String -- ^ function transforming function names + functionNameBuilder :: FunctionName -> String -- ^ function generating function names , requestBody :: String -- ^ name used when a user want to send the request body (to let you redefine it) , successCallback :: String -- ^ name of the callback parameter when the request was successful , errorCallback :: String -- ^ name of the callback parameter when the request reported an error @@ -40,7 +40,7 @@ data CommonGeneratorOptions = CommonGeneratorOptions -- -- @ -- > defCommonGeneratorOptions = CommonGeneratorOptions --- > { functionRenamer = concatRenamer +-- > { functionNameBuilder = camelCase -- > , requestBody = "body" -- > , successCallback = "onSuccess" -- > , errorCallback = "onError" @@ -50,29 +50,29 @@ data CommonGeneratorOptions = CommonGeneratorOptions defCommonGeneratorOptions :: CommonGeneratorOptions defCommonGeneratorOptions = CommonGeneratorOptions { - functionRenamer = concatRenamer + functionNameBuilder = camelCase , requestBody = "body" , successCallback = "onSuccess" , errorCallback = "onError" , moduleName = "" } --- | Function renamer that simply concat each part together -concatRenamer :: FunctionName -> String -concatRenamer = concat +-- | Function name builder that simply concat each part together +concatCase :: FunctionName -> String +concatCase = concat --- | Function renamer using the snake_case convention. +-- | Function name builder using the snake_case convention. -- each part is separated by a single underscore character. -snakeCaseRenamer :: FunctionName -> String -snakeCaseRenamer = intercalate "_" +snakeCase :: FunctionName -> String +snakeCase = intercalate "_" --- | Function renamer using the CamelCase convention. +-- | Function name builder using the CamelCase convention. -- each part begins with an upper case character. -camelCaseRenamer :: FunctionName -> String -camelCaseRenamer [] = "" -camelCaseRenamer (p:ps) = concat $ p : camelCaseRenamer' ps - where camelCaseRenamer' [] = [] - camelCaseRenamer' (r:rs) = capitalize r : camelCaseRenamer' rs +camelCase :: FunctionName -> String +camelCase [] = "" +camelCase (p:ps) = concat $ p : camelCase' ps + where camelCase' [] = [] + camelCase' (r:rs) = capitalize r : camelCase' rs capitalize [] = [] capitalize (x:xs) = toUpper x : xs diff --git a/servant-js/src/Servant/JS/JQuery.hs b/servant-js/src/Servant/JS/JQuery.hs index be36792e..0231bb97 100644 --- a/servant-js/src/Servant/JS/JQuery.hs +++ b/servant-js/src/Servant/JS/JQuery.hs @@ -76,7 +76,7 @@ generateJQueryJSWith opts req = "\n" <> namespace = if null (moduleName opts) then "var " else (moduleName opts) <> "." - fname = namespace <> (functionRenamer opts $ req ^. funcName) + fname = namespace <> (functionNameBuilder opts $ req ^. funcName) method = req ^. reqMethod url = if url' == "'" then "'/'" else url' diff --git a/servant-js/src/Servant/JS/Vanilla.hs b/servant-js/src/Servant/JS/Vanilla.hs index c9b0fb49..ee632f95 100644 --- a/servant-js/src/Servant/JS/Vanilla.hs +++ b/servant-js/src/Servant/JS/Vanilla.hs @@ -83,7 +83,7 @@ generateVanillaJSWith opts req = "\n" <> namespace = if null (moduleName opts) then "var " else (moduleName opts) <> "." - fname = namespace <> (functionRenamer opts $ req ^. funcName) + fname = namespace <> (functionNameBuilder opts $ req ^. funcName) method = req ^. reqMethod url = if url' == "'" then "'/'" else url'