eeva/servant
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add tests for a more complete server with capture all branches.

Browse source 
* This fails two of the tests.  We should probably add a catch all
    at the end that captures anything not matches by the Symbols for
    the preceding branches `arms` and `legs`.
  * When using `CaptureAll` from the root "/" and empty path becomes
    an empty list.  when using it from a branch though an empty path,
    ie. a trailing separator, becomes `mempty` for the type.  Where is
    this happening?  I think this is definitely happening before
    `parseUrlpieces` gets run, so it happens in the machinery for
    Delayed and DelayedIO.  I am still looking for the code that
    produces the `txts` argument for the `captureD` lambda created in
    the `HasServer` instance for `CaptureAll`.
This commit is contained in:
Guy Gastineau 2022-01-25 13:38:58 -05:00
parent 7a770b5a1e
commit ea96794763
No known key found for this signature in database
GPG key ID: BC92DE181D2AF254
1 changed files with 27 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
servant-server/test/Servant/ServerSpec.hs
View file

@ -268,14 +268,17 @@ captureSpec = do
-- * captureAllSpec {{{
------------------------------------------------------------------------------
type CaptureAllApi = CaptureAll "legs" Integer :> Get '[JSON] Animal
type CaptureAllApi = "legs" :> CaptureAll "legs" Integer :> Get '[JSON] Animal
:<|> "arms" :> CaptureAll "arms" String :> Get '[JSON] [String]
captureAllApi :: Proxy CaptureAllApi
captureAllApi = Proxy
captureAllServer :: [Integer] -> Handler Animal
captureAllServer legs = case sum legs of
captureAllServer :: Server CaptureAllApi
captureAllServer = handleLegs :<|> (return :: [String] -> Handler [String])
where
handleLegs [] = return beholder
handleLegs legs = case sum legs of
4 -> return jerry
2 -> return tweety
0 -> return beholder
_ -> throwError err404
captureAllSpec :: Spec
@ -284,29 +287,39 @@ captureAllSpec = do
with (return (serve captureAllApi captureAllServer)) $ do
it "can capture a single element of the 'pathInfo'" $ do
response <- get "/2"
response <- get "/legs/2"
liftIO $ decode' (simpleBody response) `shouldBe` Just tweety
it "can capture multiple elements of the 'pathInfo'" $ do
response <- get "/2/2"
response <- get "/legs/2/2"
liftIO $ decode' (simpleBody response) `shouldBe` Just jerry
it "can capture arbitrarily many elements of the 'pathInfo'" $ do
response <- get "/1/1/0/1/0/1"
response <- get "/legs/1/1/0/1/0/1"
liftIO $ decode' (simpleBody response) `shouldBe` Just jerry
it "can capture when there are no elements in 'pathInfo'" $ do
response <- get "/"
response <- get "/legs/"
liftIO $ decode' (simpleBody response) `shouldBe` Just beholder
it "returns 400 if the decoding fails" $ do
get "/notAnInt" `shouldRespondWith` 400
get "/legs/notAnInt" `shouldRespondWith` 400
it "returns 400 if the decoding fails, regardless of which element" $ do
get "/1/0/0/notAnInt/3/" `shouldRespondWith` 400
get "/legs/1/0/0/notAnInt/3/" `shouldRespondWith` 400
it "returns 400 if the decoding fails, even when it's multiple elements" $ do
get "/1/0/0/notAnInt/3/orange/" `shouldRespondWith` 400
get "/legs/1/0/0/notAnInt/3/orange/" `shouldRespondWith` 400
let getStringList = decode' @[String] . simpleBody
it "can capture single String" $ do
response <- get "/arms/jerry"
liftIO $ getStringList response `shouldBe` Just ["jerry"]
it "can capture when there are no elements in 'pathinfo'" $ do
response <- get "/arms/"
liftIO $ getStringList response `shouldBe` Just []
with (return (serve
(Proxy :: Proxy (CaptureAll "segments" String :> Raw))