eeva/servant
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Accept wider range of return codes

Browse source 
DELETE
201 doesn't make sense
I think we can get away with just 204 without 205 and 206

GET
206 should be handled by the lib itself (?) so we only add 203

Closes #20
This commit is contained in:
Mateusz Kowalczyk 2015-03-25 15:34:58 +00:00
parent c08baabfdf
commit d21f0bbbfc
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Servant/Client.hs
View file

@ -111,7 +111,7 @@ instance HasClient Delete where
type Client Delete = BaseUrl -> EitherT ServantError IO () type Client Delete = BaseUrl -> EitherT ServantError IO ()
clientWithRoute Proxy req host = clientWithRoute Proxy req host =
void $ performRequest H.methodDelete req (== 204) host void $ performRequest H.methodDelete req (`elem` [200, 202, 204]) host
-- | If you have a 'Get' endpoint in your API, the client -- | If you have a 'Get' endpoint in your API, the client
-- side querying function that is created when calling 'client' -- side querying function that is created when calling 'client'
@ -120,7 +120,7 @@ instance HasClient Delete where
instance (MimeUnrender ct result) => HasClient (Get (ct ': cts) result) where instance (MimeUnrender ct result) => HasClient (Get (ct ': cts) result) where
type Client (Get (ct ': cts) result) = BaseUrl -> EitherT ServantError IO result type Client (Get (ct ': cts) result) = BaseUrl -> EitherT ServantError IO result
clientWithRoute Proxy req host = clientWithRoute Proxy req host =
performRequestCT (Proxy :: Proxy ct) H.methodGet req [200] host performRequestCT (Proxy :: Proxy ct) H.methodGet req [200, 203] host
-- | If you use a 'Header' in one of your endpoints in your API, -- | If you use a 'Header' in one of your endpoints in your API,
-- the corresponding querying function will automatically take -- the corresponding querying function will automatically take