From c1c631eaff818aac6939646dfcbf45bc1ef25411 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20Deest?= Date: Tue, 22 Mar 2022 11:56:18 +0100 Subject: [PATCH] Add changelog entry --- changelog.d/1569 | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 changelog.d/1569 diff --git a/changelog.d/1569 b/changelog.d/1569 new file mode 100644 index 00000000..47585f6c --- /dev/null +++ b/changelog.d/1569 @@ -0,0 +1,13 @@ +synopsis: Encode captures using toEncodedUrlPiece +prs: #1569 +issues: #1511 + +description: { +The `servant-client` library now makes direct use of `toEncodedUrlPiece` from `ToHttpApiData` +to encode captured values when building the request path. It gives user freedom to implement +URL-encoding however they need. + +Previous behavior was to use `toUrlPiece` and URL-encode its output using `toEncodedUrlPiece` +from the `Text` instance of `ToHttpApiData`. The issue with this approach is that +`ToHttpApiData Text` is overly zealous and also encodes characters, such as `*`, which are perfectly valid in a URL. +}