eeva/servant
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove ToSample a => ToSample [a] instance

Browse source 
`ToSample [a]` was generating an infinite list of samples. This is far from
being useful; if you have two samples for `a` servant-docs generates 79kloc long
samples for `[a]`.

Because it's impossible to come up with a useful `ToSample [a]` that works for
all use cases, we leave that out.
This commit is contained in:
Ömer Sinan Ağacan 2017-08-25 15:00:04 +03:00
parent 50be3a263b
commit 747765c269
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
servant-docs/CHANGELOG.md
View file

@ -6,6 +6,8 @@
* Add a markdown header for the Headers an endpoint is sensitive to. * Add a markdown header for the Headers an endpoint is sensitive to.
* Document the HTTP Method the parameters of an endpoint belong to * Document the HTTP Method the parameters of an endpoint belong to
(rather than assuming `GET` for all of them). (rather than assuming `GET` for all of them).
* Remove `ToSample a => ToSample [a]` and `ToSample (ZipList a)` instances
(https://github.com/haskell-servant/servant/pull/797).
0.11 0.11
---- ----

2
servant-docs/src/Servant/Docs/Internal.hs
View file

@ -895,11 +895,9 @@ instance (ToSample a, ToSample b, ToSample c, ToSample d, ToSample e, ToSample f
instance ToSample a => ToSample (Maybe a) instance ToSample a => ToSample (Maybe a)
instance (ToSample a, ToSample b) => ToSample (Either a b) instance (ToSample a, ToSample b) => ToSample (Either a b)
instance ToSample a => ToSample [a]
-- ToSample instances for Control.Applicative types -- ToSample instances for Control.Applicative types
instance ToSample a => ToSample (Const a b) instance ToSample a => ToSample (Const a b)
instance ToSample a => ToSample (ZipList a)
-- ToSample instances for Data.Monoid newtypes -- ToSample instances for Data.Monoid newtypes
instance ToSample All instance ToSample All