eeva/nixos-hardware
1
0
Fork 0
mirror of https://github.com/NixOS/nixos-hardware synced 2024-11-26 21:09:42 +01:00
Code Issues Releases Wiki Activity

system76: Remove kernel param ec_sys.write_support=1.

Browse source 
I don't think we need this in the generic configuration.  There is a call to
`modprobe ec_sys.write_support=1` in system76-driver, only for the airplane mode
daemon (which only applies to certain models, not including darp6), and the
driver executes the modprobe call anyhow.

Also the kernel's documentation for the parameter says:

    write_support:Dangerous, reboot and removal of battery may be needed. (bool)

So let's only enable this where it's required.
This commit is contained in:
Bryan Gardiner 2020-10-12 18:06:11 -07:00
parent d86324ba69
commit fdc0812787
No known key found for this signature in database
GPG key ID: 53EFBCA063E6183C
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
system76/default.nix
View file

@ -6,8 +6,5 @@
{
imports = [ ../common/pc ];
# This seems to be required for system76-driver.
boot.kernelParams = [ "ec_sys.write_support=1" ];
hardware.system76.enableAll = lib.mkDefault true;
}