From fdc0812787828fd4a373f9c4c80cbb8d862b3f22 Mon Sep 17 00:00:00 2001 From: Bryan Gardiner Date: Mon, 12 Oct 2020 18:06:11 -0700 Subject: [PATCH] system76: Remove kernel param ec_sys.write_support=1. I don't think we need this in the generic configuration. There is a call to `modprobe ec_sys.write_support=1` in system76-driver, only for the airplane mode daemon (which only applies to certain models, not including darp6), and the driver executes the modprobe call anyhow. Also the kernel's documentation for the parameter says: write_support:Dangerous, reboot and removal of battery may be needed. (bool) So let's only enable this where it's required. --- system76/default.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/system76/default.nix b/system76/default.nix index e09a989..8a881c0 100644 --- a/system76/default.nix +++ b/system76/default.nix @@ -6,8 +6,5 @@ { imports = [ ../common/pc ]; - # This seems to be required for system76-driver. - boot.kernelParams = [ "ec_sys.write_support=1" ]; - hardware.system76.enableAll = lib.mkDefault true; }