From d1d99eb15887cedb0d6dba66e4482c53cb809c1d Mon Sep 17 00:00:00 2001
From: Yegor Timoshenko <yegortimoshenko@gmail.com>
Date: Mon, 25 Dec 2017 21:26:29 +0000
Subject: [PATCH] treewide: mark things that have to be done

---
 acer/aspire/4810t/default.nix       | 5 +++--
 apple/macbook-pro/10-1/default.nix  | 2 +-
 audio-gd/compass2.nix               | 4 +---
 lenovo/thinkpad/t410/default.nix    | 2 ++
 lenovo/thinkpad/t440p/default.nix   | 1 +
 lenovo/thinkpad/x220/default.nix    | 2 +-
 microsoft/surface-pro/3/default.nix | 1 +
 samsung/np900x3c/default.nix        | 2 ++
 8 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/acer/aspire/4810t/default.nix b/acer/aspire/4810t/default.nix
index f21d630..d40b454 100644
--- a/acer/aspire/4810t/default.nix
+++ b/acer/aspire/4810t/default.nix
@@ -14,14 +14,15 @@
       "vga=0x317"
       "video=vesafb:ywrap"
 
-      # Important, to disable Kernel Mode Setting for the graphics card
-      # This will allow backlight regulation
+      # Important, disable KMS to fix backlight regulation:
       "nomodeset"
     ];
   };
 
+  # TODO: reverse compat
   hardware.opengl.driSupport = false;
 
+  # TODO: reverse compat
   services.xserver = {
     defaultDepth = lib.mkDefault 24;
   };
diff --git a/apple/macbook-pro/10-1/default.nix b/apple/macbook-pro/10-1/default.nix
index 06e7486..e029ef2 100644
--- a/apple/macbook-pro/10-1/default.nix
+++ b/apple/macbook-pro/10-1/default.nix
@@ -10,7 +10,7 @@
   boot.loader.systemd-boot.enable = true;
   boot.loader.efi.canTouchEfiVariables = true;
 
-  # TODO: drop
+  # TODO: reverse compat
   hardware.opengl.driSupport32Bit = true;
 
   services.xserver = {
diff --git a/audio-gd/compass2.nix b/audio-gd/compass2.nix
index 6115572..5268c1d 100644
--- a/audio-gd/compass2.nix
+++ b/audio-gd/compass2.nix
@@ -1,8 +1,6 @@
-{ config, pkgs, ... }:
-
 {
   boot = {
-    extraModprobeConfig = ''
+    extraModprobeConfig = lib.mkDefault ''
       options snd slots=snd_usb_audio,snd-hda-intel
     '';
   };
diff --git a/lenovo/thinkpad/t410/default.nix b/lenovo/thinkpad/t410/default.nix
index 737e91f..c40801f 100644
--- a/lenovo/thinkpad/t410/default.nix
+++ b/lenovo/thinkpad/t410/default.nix
@@ -8,6 +8,8 @@
   ];
 
   boot = {
+    # TODO: this configuration seems to be very aggressive.
+    # Ask @peti if it's stable or not.
     kernelParams = [
       "drm.debug=0"
       "drm.vblankoffdelay=1"
diff --git a/lenovo/thinkpad/t440p/default.nix b/lenovo/thinkpad/t440p/default.nix
index 464c874..4dd4085 100644
--- a/lenovo/thinkpad/t440p/default.nix
+++ b/lenovo/thinkpad/t440p/default.nix
@@ -10,6 +10,7 @@
     extraModprobeConfig = lib.mkDefault ''
       options bbswitch use_acpi_to_detect_card_state=1
     '';
+    # TODO: probably enable tcsd? Is this line necessary?
     kernelModules = [ "tpm-rng" ];
   };
 }
diff --git a/lenovo/thinkpad/x220/default.nix b/lenovo/thinkpad/x220/default.nix
index e821f96..3cf18e3 100644
--- a/lenovo/thinkpad/x220/default.nix
+++ b/lenovo/thinkpad/x220/default.nix
@@ -4,7 +4,7 @@
   imports = [
     ../.
     ../../../common/cpu/intel
-    ../../../common/pc/laptop/hdd
+    ../../../common/pc/laptop/hdd # TODO: reverse compat
     ../tp-smapi.nix
   ];
 }
diff --git a/microsoft/surface-pro/3/default.nix b/microsoft/surface-pro/3/default.nix
index 70442e6..a09c60b 100644
--- a/microsoft/surface-pro/3/default.nix
+++ b/microsoft/surface-pro/3/default.nix
@@ -4,5 +4,6 @@
   # to use the type cover in the initrd
   boot.kernelModules = [ "hid-microsoft" ];
 
+  # TODO: reverse compat
   networking.wireless.enable = lib.mkDefault true;
 }
diff --git a/samsung/np900x3c/default.nix b/samsung/np900x3c/default.nix
index 8f19af5..ced3d70 100644
--- a/samsung/np900x3c/default.nix
+++ b/samsung/np900x3c/default.nix
@@ -1,3 +1,5 @@
+# TODO: use ../../common/pc/laptop
+
 { lib, ... }:
 
 {