From 9821d2c5438edbb567190377bcec4b640ad100c6 Mon Sep 17 00:00:00 2001
From: Matei Dibu <contact@mateidibu.dev>
Date: Wed, 24 Apr 2024 16:33:39 +0300
Subject: [PATCH] asus/pro-ws-x570-ace: init

---
 README.md                        |  1 +
 asus/pro-ws-x570-ace/README.wiki | 29 +++++++++++++++++++++++++++++
 asus/pro-ws-x570-ace/default.nix | 19 +++++++++++++++++++
 flake.nix                        |  1 +
 4 files changed, 50 insertions(+)
 create mode 100644 asus/pro-ws-x570-ace/README.wiki
 create mode 100644 asus/pro-ws-x570-ace/default.nix

diff --git a/README.md b/README.md
index 207f4ca..4f00d86 100644
--- a/README.md
+++ b/README.md
@@ -82,6 +82,7 @@ See code for all available configurations.
 | [Apple MacBook Pro 14,1](apple/macbook-pro/14-1)                       | `<nixos-hardware/apple/macbook-pro/14-1>`               |
 | [Apple MacMini (2010, Intel, Nvidia)](apple/macmini/4)                 | `<nixos-hardware/apple/macmini/4>`                      |
 | [Apple Macs with a T2 Chip](apple/t2)                                  | `<nixos-hardware/apple/t2>`                             |
+| [Asus Pro WS X570-ACE](asus/pro-ws-x570-ace)                           | `<nixos-hardware/asus/pro-ws-x570-ace>`                 |
 | [Asus ROG Ally RC71L (2023)](asus/ally/rc71l)                          | `<nixos-hardware/asus/ally/rc71l>`                      |
 | [Asus ROG Strix G513IM](asus/rog-strix/g513im)                         | `<nixos-hardware/asus/rog-strix/g513im>`                |
 | [Asus ROG Strix G733QS](asus/rog-strix/g733qs)                         | `<nixos-hardware/asus/rog-strix/g733qs>`                |
diff --git a/asus/pro-ws-x570-ace/README.wiki b/asus/pro-ws-x570-ace/README.wiki
new file mode 100644
index 0000000..33ecf52
--- /dev/null
+++ b/asus/pro-ws-x570-ace/README.wiki
@@ -0,0 +1,29 @@
+= ASUS Pro WS X570-ACE =
+
+== Firmware issues ==
+
+=== BIOS ===
+
+BIOS version 4805 (and possibly older) has broken <code>X2APIC</code> mode, which in turn breaks <code>amd-pstate</code> support.
+Other possible config values for <code>APIC</code> are <code>Compatibility</code>, <code>Auto</code> and <code>XAPIC</code>; best results were observed with <code>XAPIC</code>.
+
+This is the error in dmesg when <code>X2APIC</code> is enabled:
+
+<code>
+amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled
+</code>
+
+=== IPMI ===
+
+The IPMI is half-baked and for the most part unusable in a pure Linux environment, see https://forum.level1techs.com/t/remote-management-on-the-asus-pro-ws-x570-ace-under-linux
+
+== Firmware features ==
+
+=== IOMMU ===
+
+The groups are great, it's a good board for VFIO.
+
+=== ECC Memory ===
+
+As stated on the product page, it works; explicitly enabling in BIOS might be required.
+Tested with <code>M391A2K43BB1-CTD</code>.
diff --git a/asus/pro-ws-x570-ace/default.nix b/asus/pro-ws-x570-ace/default.nix
new file mode 100644
index 0000000..0fcde58
--- /dev/null
+++ b/asus/pro-ws-x570-ace/default.nix
@@ -0,0 +1,19 @@
+{
+  imports = [
+    ../../common/pc
+    ../../common/pc/ssd
+    ../../common/cpu/amd/pstate.nix
+  ];
+
+  boot.kernelModules = [
+    # Nuvoton NCT6798D - temperature, voltage and RPM
+    "nct6775"
+
+    # a single "temp1" sensor, always at "+31.9°C"
+    # commented because it's not useful, but left here for reference
+    # Bus `SMBus PIIX4 adapter port 1 at 0b20'
+    # Busdriver `i2c_piix4', I2C address 0x4f
+    # Chip `ds75'
+    # "lm75"
+  ];
+}
diff --git a/flake.nix b/flake.nix
index cabdabc..d68cdc0 100644
--- a/flake.nix
+++ b/flake.nix
@@ -19,6 +19,7 @@
       asus-ally-rc71l = import ./asus/ally/rc71l;
       asus-fx504gd = import ./asus/fx504gd;
       asus-fa507rm = import ./asus/fa507rm;
+      asus-pro-ws-x570-ace = import ./asus/pro-ws-x570-ace;
       asus-rog-strix-g513im = import ./asus/rog-strix/g513im;
       asus-rog-strix-g733qs = import ./asus/rog-strix/g733qs;
       asus-zephyrus-ga401 = import ./asus/zephyrus/ga401;