From 26bbc980b9b7c6b0d38b51fec5b41e977731fb5c Mon Sep 17 00:00:00 2001
From: Ashley Gillman <gillmanash@gmail.com>
Date: Sun, 15 Jul 2018 22:28:25 +0100
Subject: [PATCH] Add Dell E7240 Profile

(Current XPS 15 works well)
---
 README.md              | 82 ++++++++++++++++++++++--------------------
 dell/e7240/README.md   |  8 +++++
 dell/e7240/default.nix |  8 +++++
 release.nix            |  1 +
 4 files changed, 60 insertions(+), 39 deletions(-)
 create mode 100644 dell/e7240/README.md
 create mode 100644 dell/e7240/default.nix

diff --git a/README.md b/README.md
index bd57ba3..e852161 100644
--- a/README.md
+++ b/README.md
@@ -24,48 +24,52 @@ imports = [
 
 See code for all available configurations.
 
-| Model                             | Path                                         |
-| --------------------------------- | -------------------------------------------- |
-| [Acer Aspire 4810T][]             | `<nixos-hardware/acer/aspire/4810t>`         |
-| Airis N990                        | `<nixos-hardware/airis/n990>`                |
-| Apple MacBook Air 4,X             | `<nixos-hardware/apple/macbook-air/4>`       |
-| Apple MacBook Air 6,X             | `<nixos-hardware/apple/macbook-air/6>`       |
-| [Apple MacBook Pro 10,1][]        | `<nixos-hardware/apple/macbook-pro/10-1>`    |
-| Apple MacBook Pro 12,1            | `<nixos-hardware/apple/macbook-pro/12-1>`    |
-| BeagleBoard PocketBeagle          | `<nixos-hardware/beagleboard/pocketbeagle>`  |
-| [Dell XPS 13 9360][]              | `<nixos-hardware/dell/xps/13-9360>`          |
-| [Dell XPS 13 9370][]              | `<nixos-hardware/dell/xps/13-9370>`          |
-| [Dell XPS 13 9380][]              | `<nixos-hardware/dell/xps/13-9380>`          |
-| [Dell XPS 15 9550][]              | `<nixos-hardware/dell/xps/15-9550>`          |
-| [Inverse Path USB armory][]       | `<nixos-hardware/inversepath/usbarmory>`     |
-| Lenovo IdeaPad Z510               | `<nixos-hardware/lenovo/ideapad/z510>`       |
-| Lenovo ThinkPad T410              | `<nixos-hardware/lenovo/thinkpad/t410>`      |
-| Lenovo ThinkPad T430              | `<nixos-hardware/lenovo/thinkpad/t430>`      |
-| Lenovo ThinkPad T440s             | `<nixos-hardware/lenovo/thinkpad/t440s>`     |
-| Lenovo ThinkPad T440p             | `<nixos-hardware/lenovo/thinkpad/t440p>`     |
-| Lenovo ThinkPad T450s             | `<nixos-hardware/lenovo/thinkpad/t450s>`     |
-| Lenovo ThinkPad T460s             | `<nixos-hardware/lenovo/thinkpad/t460s>`     |
-| Lenovo ThinkPad T470s             | `<nixos-hardware/lenovo/thinkpad/t470s>`     |
-| Lenovo ThinkPad T480s             | `<nixos-hardware/lenovo/thinkpad/t480s>`     |
-| Lenovo ThinkPad T490              | `<nixos-hardware/lenovo/thinkpad/t490>`      |
-| Lenovo ThinkPad X140e             | `<nixos-hardware/lenovo/thinkpad/x140e>`     |
-| Lenovo ThinkPad X220              | `<nixos-hardware/lenovo/thinkpad/x220>`      |
-| Lenovo ThinkPad X230              | `<nixos-hardware/lenovo/thinkpad/x230>`      |
-| Lenovo ThinkPad X250              | `<nixos-hardware/lenovo/thinkpad/x250>`      |
-| [Lenovo ThinkPad X260][]          | `<nixos-hardware/lenovo/thinkpad/x260>`      |
-| Lenovo ThinkPad X270              | `<nixos-hardware/lenovo/thinkpad/x270>`      |
-| [Lenovo ThinkPad X1 (6th Gen)][]  | `<nixos-hardware/lenovo/thinkpad/x1/6th-gen>`|
-| [Microsoft Surface Pro 3][]       | `<nixos-hardware/microsoft/surface-pro/3>`   |
-| PC Engines APU                    | `<nixos-hardware/pcengines/apu>`             |
-| [Raspberry Pi 2][]                | `<nixos-hardware/raspberry-pi/2>`            |
-| [Samsung Series 9 NP900X3C][]     | `<nixos-hardware/samsung/np900x3c>`          |
-| [Purism Librem 13v3][]            | `<nixos-hardware/purism/librem/13v3>`        |
-| Supermicro A1SRi-2758F            | `<nixos-hardware/supermicro/a1sri-2758f>`    |
-| Supermicro X10SLL-F               | `<nixos-hardware/supermicro/x10sll-f>`       |
-| [Toshiba Chromebook 2 `swanky`][] | `<nixos-hardware/toshiba/swanky>`            |
+
+
+| Model                             | Path                                          |
+| --------------------------------- | --------------------------------------------  |
+| [Acer Aspire 4810T][]             | `<nixos-hardware/acer/aspire/4810t>`          |
+| Airis N990                        | `<nixos-hardware/airis/n990>`                 |
+| Apple MacBook Air 4,X             | `<nixos-hardware/apple/macbook-air/4>`        |
+| Apple MacBook Air 6,X             | `<nixos-hardware/apple/macbook-air/6>`        |
+| [Apple MacBook Pro 10,1][]        | `<nixos-hardware/apple/macbook-pro/10-1>`     |
+| Apple MacBook Pro 12,1            | `<nixos-hardware/apple/macbook-pro/12-1>`     |
+| BeagleBoard PocketBeagle          | `<nixos-hardware/beagleboard/pocketbeagle>`   |
+| [Dell XPS E7240][]                | `<nixos-hardware/dell/e7240>`                 |
+| [Dell XPS 13 9360][]              | `<nixos-hardware/dell/xps/13-9360>`           |
+| [Dell XPS 13 9370][]              | `<nixos-hardware/dell/xps/13-9370>`           |
+| [Dell XPS 13 9380][]              | `<nixos-hardware/dell/xps/13-9380>`           |
+| [Dell XPS 15 9550][]              | `<nixos-hardware/dell/xps/15-9550>`           |
+| [Inverse Path USB armory][]       | `<nixos-hardware/inversepath/usbarmory>`      |
+| Lenovo IdeaPad Z510               | `<nixos-hardware/lenovo/ideapad/z510>`        |
+| Lenovo ThinkPad T410              | `<nixos-hardware/lenovo/thinkpad/t410>`       |
+| Lenovo ThinkPad T430              | `<nixos-hardware/lenovo/thinkpad/t430>`       |
+| Lenovo ThinkPad T440s             | `<nixos-hardware/lenovo/thinkpad/t440s>`      |
+| Lenovo ThinkPad T440p             | `<nixos-hardware/lenovo/thinkpad/t440p>`      |
+| Lenovo ThinkPad T450s             | `<nixos-hardware/lenovo/thinkpad/t450s>`      |
+| Lenovo ThinkPad T460s             | `<nixos-hardware/lenovo/thinkpad/t460s>`      |
+| Lenovo ThinkPad T470s             | `<nixos-hardware/lenovo/thinkpad/t470s>`      |
+| Lenovo ThinkPad T480s             | `<nixos-hardware/lenovo/thinkpad/t480s>`      |
+| Lenovo ThinkPad T490              | `<nixos-hardware/lenovo/thinkpad/t490>`       |
+| Lenovo ThinkPad X140e             | `<nixos-hardware/lenovo/thinkpad/x140e>`      |
+| Lenovo ThinkPad X220              | `<nixos-hardware/lenovo/thinkpad/x220>`       |
+| Lenovo ThinkPad X230              | `<nixos-hardware/lenovo/thinkpad/x230>`       |
+| Lenovo ThinkPad X250              | `<nixos-hardware/lenovo/thinkpad/x250>`       |
+| [Lenovo ThinkPad X260][]          | `<nixos-hardware/lenovo/thinkpad/x260>`       |
+| Lenovo ThinkPad X270              | `<nixos-hardware/lenovo/thinkpad/x270>`       |
+| [Lenovo ThinkPad X1 (6th Gen)][]  | `<nixos-hardware/lenovo/thinkpad/x1/6th-gen>` |
+| [Microsoft Surface Pro 3][]       | `<nixos-hardware/microsoft/surface-pro/3>`    |
+| PC Engines APU                    | `<nixos-hardware/pcengines/apu>`              |
+| [Raspberry Pi 2][]                | `<nixos-hardware/raspberry-pi/2>`             |
+| [Samsung Series 9 NP900X3C][]     | `<nixos-hardware/samsung/np900x3c>`           |
+| [Purism Librem 13v3][]            | `<nixos-hardware/purism/librem/13v3>`         |
+| Supermicro A1SRi-2758F            | `<nixos-hardware/supermicro/a1sri-2758f>`     |
+| Supermicro X10SLL-F               | `<nixos-hardware/supermicro/x10sll-f>`        |
+| [Toshiba Chromebook 2 `swanky`][] | `<nixos-hardware/toshiba/swanky>`             |
 
 [Acer Aspire 4810T]: acer/aspire/4810t
 [Apple MacBook Pro 10,1]: apple/macbook-pro/10-1
+[Dell XPS E7240][]: dell/e7240
 [Dell XPS 13 9360]: dell/xps/13-9360
 [Dell XPS 13 9370]: dell/xps/13-9370
 [Dell XPS 13 9380]: dell/xps/13-9380
diff --git a/dell/e7240/README.md b/dell/e7240/README.md
new file mode 100644
index 0000000..b712f4d
--- /dev/null
+++ b/dell/e7240/README.md
@@ -0,0 +1,8 @@
+On some kernel versions user ashgillman has experiences suspend issues
+(see https://bugzilla.redhat.com/show_bug.cgi?id=1597481).
+
+Try:
+
+```nix
+boot.kernelPackages = pkgs.linuxPackages_4_14;
+```
diff --git a/dell/e7240/default.nix b/dell/e7240/default.nix
new file mode 100644
index 0000000..3334a74
--- /dev/null
+++ b/dell/e7240/default.nix
@@ -0,0 +1,8 @@
+{ lib, pkgs, ... }:
+
+{
+  imports = [
+    ../../common/cpu/intel
+    ../../common/pc/laptop
+  ];
+}
diff --git a/release.nix b/release.nix
index 11ba888..ecc3ec7 100644
--- a/release.nix
+++ b/release.nix
@@ -31,6 +31,7 @@ in
   apple-macbook-pro-11-5 = buildProfile ./apple/macbook-pro/11-5;
   apple-macbook-pro-12-1 = buildProfile ./apple/macbook-pro/12-1;
 
+  dell-e7240 = buildProfile ./dell/e7240;
   dell-xps-13-9380 = buildProfile ./dell/xps/13-9380;
   dell-xps-13-9370 = buildProfile ./dell/xps/13-9370;
   dell-xps-15-9550 = buildProfile ./dell/xps/15-9550;