Merge pull request #395 from stweil/master

Catch a CGenErr by const reference rather than by value

src/clientdlg.cpp

@@ -1079,7 +1079,7 @@ void CClientDlg::Connect ( const QString& strSelectedAddress,
             }
         }
 
-        catch ( CGenErr generr )
+        catch ( const CGenErr& generr )
         {
             // show error message and return the function
             QMessageBox::critical ( this, APP_NAME, generr.GetErrorText(), "Close", nullptr );

src/global.h

@@ -282,7 +282,7 @@ public:
     CGenErr ( QString strNewErrorMsg, QString strNewErrorType = "" ) :
         strErrorMsg ( strNewErrorMsg ), strErrorType ( strNewErrorType ) {}
 
-    QString GetErrorText()
+    QString GetErrorText() const
     {
         // return formatted error text
         if ( strErrorType.isEmpty() )

src/main.cpp

@@ -706,7 +706,7 @@ int main ( int argc, char** argv )
         }
     }
 
-    catch ( CGenErr generr )
+    catch ( const CGenErr& generr )
     {
         // show generic error
 #ifndef HEADLESS