eeva/jamulus
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #395 from stweil/master

Browse source 
Catch a CGenErr by const reference rather than by value
This commit is contained in:
Volker Fischer 2020-06-24 17:19:47 +02:00 committed by GitHub
commit faef894057
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/clientdlg.cpp
View file

@ -1079,7 +1079,7 @@ void CClientDlg::Connect ( const QString& strSelectedAddress,
} }
} }
catch ( CGenErr generr ) catch ( const CGenErr& generr )
{ {
// show error message and return the function // show error message and return the function
QMessageBox::critical ( this, APP_NAME, generr.GetErrorText(), "Close", nullptr ); QMessageBox::critical ( this, APP_NAME, generr.GetErrorText(), "Close", nullptr );

2
src/global.h
View file

@ -282,7 +282,7 @@ public:
CGenErr ( QString strNewErrorMsg, QString strNewErrorType = "" ) : CGenErr ( QString strNewErrorMsg, QString strNewErrorType = "" ) :
strErrorMsg ( strNewErrorMsg ), strErrorType ( strNewErrorType ) {} strErrorMsg ( strNewErrorMsg ), strErrorType ( strNewErrorType ) {}
QString GetErrorText() QString GetErrorText() const
{ {
// return formatted error text // return formatted error text
if ( strErrorType.isEmpty() ) if ( strErrorType.isEmpty() )

2
src/main.cpp
View file

@ -706,7 +706,7 @@ int main ( int argc, char** argv )
} }
} }
catch ( CGenErr generr ) catch ( const CGenErr& generr )
{ {
// show generic error // show generic error
#ifndef HEADLESS #ifndef HEADLESS