From c2d98c865e6e9621640ccc4efa4a0907bad8b25c Mon Sep 17 00:00:00 2001 From: Volker Fischer Date: Thu, 2 Jul 2020 18:38:26 +0200 Subject: [PATCH] fix: if group, set one fader to 0, set mute, move fader up, unmute -> no grouping anymore --- ChangeLog | 1 - src/audiomixerboard.cpp | 6 ------ 2 files changed, 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index ef2deccb..1dc7efff 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,7 +10,6 @@ - bug fix: grouping faders in the client should be proportional (see discussion in #202, #419) -TODO fix: if group, set one fader to 0, set mute, move fader up, unmute -> no grouping anymore TODO bug fix: incorrect selection of UI language (#408) !!!!!!!!!!!!!!!!!!!!!!!!!!!!! -> note that for the 3.5.8 bug fix release we went back to the original translation code (e.g. no pt_BR!) diff --git a/src/audiomixerboard.cpp b/src/audiomixerboard.cpp index 172b68d2..1ec1bd14 100755 --- a/src/audiomixerboard.cpp +++ b/src/audiomixerboard.cpp @@ -455,12 +455,6 @@ void CChannelFader::SetMute ( const bool bState ) { // mute was unchecked, get current fader value and apply emit gainValueChanged ( CalcFaderGain ( GetFaderLevel() ), bIsMyOwnFader, false, false, -1 ); // set level ratio to in invalid value - -// TODO When mute or solo is activated, the group synchronization does not work anymore. -// To get a smoother experience, we adjust the previous level as soon as the mute is -// again set to off (if we would not do that, on the next move of the fader the other -// faders in the group would jump which is very bad). - dPreviousFaderLevel = GetFaderLevel(); } } }