Merge pull request #386 from atsampson/valgrind1

Fix some more Valgrind warnings

src/audiomixerboard.cpp

@@ -704,6 +704,14 @@ CAudioMixerBoard::CAudioMixerBoard ( QWidget* parent, Qt::WindowFlags ) :
     connectFaderSignalsToMixerBoardSlots<MAX_NUM_CHANNELS>();
 }
 
+CAudioMixerBoard::~CAudioMixerBoard()
+{
+    for ( int i = 0; i < MAX_NUM_CHANNELS; i++ )
+    {
+        delete vecpChanFader[i];
+    }
+}
+
 template<unsigned int slotId>
 inline void CAudioMixerBoard::connectFaderSignalsToMixerBoardSlots()
 {

src/audiomixerboard.h

@@ -169,6 +169,8 @@ public:
     CAudioMixerBoard ( QWidget*        parent = nullptr,
                        Qt::WindowFlags f      = nullptr );
 
+    virtual ~CAudioMixerBoard();
+
     void HideAll();
     void ApplyNewConClientList ( CVector<CChannelInfo>& vecChanInfo );
     void SetServerName ( const QString& strNewServerName );

src/client.cpp

@@ -220,6 +220,23 @@ CClient::CClient ( const quint16  iPortNumber,
     }
 }
 
+CClient::~CClient()
+{
+    // free audio encoders and decoders
+    opus_custom_encoder_destroy ( OpusEncoderMono );
+    opus_custom_decoder_destroy ( OpusDecoderMono );
+    opus_custom_encoder_destroy ( OpusEncoderStereo );
+    opus_custom_decoder_destroy ( OpusDecoderStereo );
+    opus_custom_encoder_destroy ( Opus64EncoderMono );
+    opus_custom_decoder_destroy ( Opus64DecoderMono );
+    opus_custom_encoder_destroy ( Opus64EncoderStereo );
+    opus_custom_decoder_destroy ( Opus64DecoderStereo );
+
+    // free audio modes
+    opus_custom_mode_destroy ( OpusMode );
+    opus_custom_mode_destroy ( Opus64Mode );
+}
+
 void CClient::OnSendProtMessage ( CVector<uint8_t> vecMessage )
 {
     // the protocol queries me to call the function to send the message

src/client.h

@@ -110,6 +110,8 @@ public:
               const bool     bNoAutoJackConnect,
               const QString& strNClientName );
 
+    virtual ~CClient();
+
     void   Start();
     void   Stop();
     bool   IsRunning() { return Sound.IsRunning(); }

src/multicolorled.cpp

@@ -37,12 +37,12 @@ CMultiColorLED::CMultiColorLED ( QWidget* parent, Qt::WindowFlags f )
     BitmCubeYellow   ( QString::fromUtf8 ( ":/png/LEDs/res/CLEDYellowSmall.png" ) ),
     BitmCubeRed      ( QString::fromUtf8 ( ":/png/LEDs/res/CLEDRedSmall.png" ) )
 {
-    // init color flags
-    Reset();
-
     // set init bitmap
     setPixmap ( BitmCubeGrey );
     eColorFlag = RL_GREY;
+
+    // init color flags
+    Reset();
 }
 
 void CMultiColorLED::changeEvent ( QEvent* curEvent )

src/server.cpp

@@ -241,6 +241,7 @@ CServer::CServer ( const int          iNewMaxNumChan,
     Logging                     ( iMaxDaysHistory ),
     iFrameCount                 ( 0 ),
     JamRecorder                 ( strRecordingDirName ),
+    bRecorderInitialised        ( false ),
     bEnableRecording            ( false ),
     bWriteStatusHTMLFile        ( false ),
     HighPrecisionTimer          ( bNUseDoubleSystemFrameSize ),
@@ -550,6 +551,26 @@ void CServer::CreateAndSendJitBufMessage ( const int iCurChanID,
     vecChannels[iCurChanID].CreateJitBufMes ( iNNumFra );
 }
 
+CServer::~CServer()
+{
+    for ( int i = 0; i < iMaxNumChannels; i++ )
+    {
+        // free audio encoders and decoders
+        opus_custom_encoder_destroy ( OpusEncoderMono[i] );
+        opus_custom_decoder_destroy ( OpusDecoderMono[i] );
+        opus_custom_encoder_destroy ( OpusEncoderStereo[i] );
+        opus_custom_decoder_destroy ( OpusDecoderStereo[i] );
+        opus_custom_encoder_destroy ( Opus64EncoderMono[i] );
+        opus_custom_decoder_destroy ( Opus64DecoderMono[i] );
+        opus_custom_encoder_destroy ( Opus64EncoderStereo[i] );
+        opus_custom_decoder_destroy ( Opus64DecoderStereo[i] );
+
+        // free audio modes
+        opus_custom_mode_destroy ( OpusMode[i] );
+        opus_custom_mode_destroy ( Opus64Mode[i] );
+    }
+}
+
 void CServer::SendProtMessage ( int iChID, CVector<uint8_t> vecMessage )
 {
     // the protocol queries me to call the function to send the message

src/server.h

@@ -183,6 +183,8 @@ public:
               const bool         bNUseDoubleSystemFrameSize,
               const ELicenceType eNLicenceType );
 
+    virtual ~CServer();
+
     void Start();
     void Stop();
     bool IsRunning() { return HighPrecisionTimer.isActive(); }

src/serverdlg.cpp

@@ -37,6 +37,9 @@ CServerDlg::CServerDlg ( CServer*        pNServP,
       BitmapSystemTrayInactive ( QString::fromUtf8 ( ":/png/LEDs/res/CLEDGreyArrow.png" ) ),
       BitmapSystemTrayActive   ( QString::fromUtf8 ( ":/png/LEDs/res/CLEDGreenArrow.png" ) )
 {
+    // check if system tray icon can be used
+    bSystemTrayIconAvaialbe = SystemTrayIcon.isSystemTrayAvailable();
+
     setupUi ( this );
 
 
@@ -143,9 +146,6 @@ CServerDlg::CServerDlg ( CServer*        pNServP,
         +  tr ( "During a recording session, the button can be used to start a new recording." ) );
 
 
-    // check if system tray icon can be used
-    bSystemTrayIconAvaialbe = SystemTrayIcon.isSystemTrayAvailable();
-
     // init system tray icon
     if ( bSystemTrayIconAvaialbe )
     {