From 7592962edaf789523525b74219083702c6489859 Mon Sep 17 00:00:00 2001 From: Volker Fischer Date: Mon, 22 Jun 2020 22:18:34 +0200 Subject: [PATCH] clip LED must be reset after a server change --- ChangeLog | 5 ++++- src/audiomixerboard.cpp | 1 + src/levelmeter.h | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index adf8d1ad..61ec49b9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -30,10 +30,13 @@ - bug fix: server window stop updating after minimized, coded by AronVietti (#355, #383) -TODO support clip indicator for bar meter as well +TODO clip LED on channel faders goes on too early (compare to input level meter clip LED) + -> only 3 of 4 bits of the channel level protocol are actually used, one bit is wasted TODO the new translation loading does not work on MacOS +TODO support clip indicator for bar meter as well + TODO https://github.com/corrados/jamulus/issues/341#issuecomment-647172946 - generate .qm on compile time with lrelease - download nsProcess.dll on Windows installer creation instead of put it in the repo diff --git a/src/audiomixerboard.cpp b/src/audiomixerboard.cpp index cc317638..b7bfdcdb 100755 --- a/src/audiomixerboard.cpp +++ b/src/audiomixerboard.cpp @@ -321,6 +321,7 @@ void CChannelFader::Reset() pcbSolo->setChecked ( false ); pcbGroup->setChecked ( false ); plbrChannelLevel->SetValue ( 0 ); + plbrChannelLevel->ClipReset(); // clear instrument picture, country flag, tool tips and label text plblLabel->setText ( "" ); diff --git a/src/levelmeter.h b/src/levelmeter.h index ce74e7ec..1c4597ff 100755 --- a/src/levelmeter.h +++ b/src/levelmeter.h @@ -95,6 +95,6 @@ protected: QTimer TimerClip; -protected slots: +public slots: void ClipReset(); };