eeva/home-manager
1
0
Fork 0
mirror of https://github.com/nix-community/home-manager synced 2024-12-20 16:59:47 +01:00
Code Issues Releases Wiki Activity

specialization: fix name conflict inside NixOS module (#3718)

Browse source 
If used inside the NixOS/nix-darwin module, we get conflicting definitions
of `name` inside the specialization: one is the user name coming from the
NixOS module definition and the other is `configuration`, the name of this
option. Thus we need to explicitly wire the former into the module arguments.

See discussion at https://github.com/nix-community/home-manager/issues/3716
This commit is contained in:
Naïm Favier 2023-02-28 22:22:22 +01:00 committed by GitHub
parent 9438e56a7b
commit ddcbf676ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
modules/misc/specialization.nix
View file

@ -1,4 +1,4 @@
{ config, extendModules, lib, ... }: { config, name, extendModules, lib, ... }:
with lib; with lib;
@ -8,8 +8,19 @@ with lib;
options = { options = {
configuration = mkOption { configuration = mkOption {
type = let type = let
stopRecursion = { specialization = mkOverride 0 { }; }; extended = extendModules {
extended = extendModules { modules = [ stopRecursion ]; }; modules = [{
# Prevent infinite recursion
specialization = mkOverride 0 { };
# If used inside the NixOS/nix-darwin module, we get conflicting definitions
# of `name` inside the specialization: one is the user name coming from the
# NixOS module definition and the other is `configuration`, the name of this
# option. Thus we need to explicitly wire the former into the module arguments.
# See discussion at https://github.com/nix-community/home-manager/issues/3716
_module.args.name = mkForce name;
}];
};
in extended.type; in extended.type;
default = { }; default = { };
visible = "shallow"; visible = "shallow";