eeva/home-manager
1
0
Fork 0
mirror of https://github.com/nix-community/home-manager synced 2024-11-26 21:19:45 +01:00
Code Issues Releases Wiki Activity

starship: replace eval with source for fish

Browse source 
Changed the initialization method from `eval` to `source` as per the
starship installation guide.

See: https://starship.rs/guide/#%F0%9F%9A%80-installation

This is in accordance with the Fish docs which recommends using `source`
if the command does not need access to stdin, which in this case is what
upstream has.

See: https://fishshell.com/docs/current/cmds/eval.html
This commit is contained in:
eljamm 2024-07-24 18:40:22 +01:00
parent 7294a99cc8
commit 49f92e9b2f
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/programs/starship.nix
View file

@ -119,7 +119,7 @@ in {
programs.fish.${initFish} = mkIf cfg.enableFishIntegration '' programs.fish.${initFish} = mkIf cfg.enableFishIntegration ''
if test "$TERM" != "dumb" if test "$TERM" != "dumb"
eval (${starshipCmd} init fish) ${starshipCmd} init fish | source
${lib.optionalString cfg.enableTransience "enable_transience"} ${lib.optionalString cfg.enableTransience "enable_transience"}
end end
''; '';

2
tests/modules/programs/starship/fish_without_interactive.nix
View file

@ -19,7 +19,7 @@ with lib;
export GOT="$(tail -n 5 `_abs home-files/.config/fish/config.fish`)" export GOT="$(tail -n 5 `_abs home-files/.config/fish/config.fish`)"
export EXPECTED=" export EXPECTED="
if test \"\$TERM\" != dumb if test \"\$TERM\" != dumb
eval (/home/hm-user/.nix-profile/bin/starship init fish) /home/hm-user/.nix-profile/bin/starship init fish | source
end" end"