From 484a1c94424d296b15af3e6858f08b576b842ec2 Mon Sep 17 00:00:00 2001 From: cvoges12 Date: Tue, 1 Aug 2023 18:44:46 -0500 Subject: [PATCH] network-manager-applet: remove `--sm-disable` flag The `--sm-disable` flag is deprecated. It doesn't show in the man pages, any documentation, and others have seemed to notice as well: > The `--sm-disable` flag isn't used anymore due to the applet no longer being session-managed. From: Which cites: PR #4296 --- modules/lib/maintainers.nix | 6 ++++++ modules/services/network-manager-applet.nix | 8 +++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/modules/lib/maintainers.nix b/modules/lib/maintainers.nix index 1f976d8ae..05d55b678 100644 --- a/modules/lib/maintainers.nix +++ b/modules/lib/maintainers.nix @@ -37,6 +37,12 @@ github = "CarlosLoboxyz"; githubId = 86011416; }; + cvoges12 = { + name = "Clayton Voges"; + email = "38054771+cvoges12@users.noreply.github.com"; + github = "cvoges12"; + githubId = 38054771; + }; d-dervishi = { email = "david.dervishi@epfl.ch"; github = "d-dervishi"; diff --git a/modules/services/network-manager-applet.nix b/modules/services/network-manager-applet.nix index f4abe86e0..b90855dd5 100644 --- a/modules/services/network-manager-applet.nix +++ b/modules/services/network-manager-applet.nix @@ -7,7 +7,7 @@ let cfg = config.services.network-manager-applet; in { - meta.maintainers = [ maintainers.rycee ]; + meta.maintainers = [ maintainers.rycee hm.maintainers.cvoges12 ]; options = { services.network-manager-applet = { @@ -32,10 +32,8 @@ in { Install = { WantedBy = [ "graphical-session.target" ]; }; Service = { - ExecStart = toString - ([ "${pkgs.networkmanagerapplet}/bin/nm-applet" "--sm-disable" ] - ++ optional config.xsession.preferStatusNotifierItems - "--indicator"); + ExecStart = toString ([ "${pkgs.networkmanagerapplet}/bin/nm-applet" ] + ++ optional config.xsession.preferStatusNotifierItems "--indicator"); }; }; };