treewide: make sure meta.maintainers evaluate

This fixes all bad maintainer values and add a CI step to validate
that no bad values remain in the future.

Closes #2587

.github/CODEOWNERS

@@ -92,7 +92,7 @@
 
 /modules/programs/go.nix                              @rvolosatovs
 
-/modules/programs/hexchat.nix                         @superherointj @thiagokokada
+/modules/programs/hexchat.nix                         @thiagokokada
 /tests/modules/programs/hexchat                       @thiagokokada
 
 /modules/programs/himalaya.nix                        @ambroisie

.github/workflows/test.yml

@@ -24,6 +24,7 @@ jobs:
           echo "Error: literalExample should be replaced by literalExpression" > /dev/stderr
           exit 1
         fi
+    - run: nix-build -A docs.jsonModuleMaintainers
     - run: ./format -c
     - run: nix-shell . -A install
     - run: nix-shell --arg enableBig false --pure tests -A run.all

default.nix

@@ -5,6 +5,7 @@ rec {
     html = manual.html;
     manPages = manPages;
     json = options.json;
+    jsonModuleMaintainers = jsonModuleMaintainers; # Unstable, mainly for CI.
   };
 
   home-manager = pkgs.callPackage ./home-manager { path = toString ./.; };

docs/default.nix

@@ -117,4 +117,14 @@ in {
   manPages = docs.manPages;
 
   manual = { inherit (docs) html htmlOpenTool; };
+
+  # Unstable, mainly for CI.
+  jsonModuleMaintainers = pkgs.writeText "hm-module-maintainers.json" (let
+    result = lib.evalModules {
+      modules = import ../modules/modules.nix {
+        inherit lib pkgs;
+        check = false;
+      } ++ [ scrubbedPkgsModule ];
+    };
+  in builtins.toJSON result.config.meta.maintainers);
 }

modules/lib/maintainers.nix

@@ -145,4 +145,28 @@
     github = "onny";
     githubId = 757752;
   };
+  aheaume = {
+    name = "aheaume";
+    email = "aheaume@users.noreply.github.com";
+    github = "aheaume";
+    githubId = 13830042;
+  };
+  t4ccer = {
+    name = "t4ccer";
+    email = "t4ccer@users.noreply.github.com";
+    github = "t4ccer";
+    githubId = 64430288;
+  };
+  nurelin = {
+    name = "nurelin";
+    email = "nurelin@users.noreply.github.com";
+    github = "nurelin";
+    githubId = 5276274;
+  };
+  pltanton = {
+    name = "pltanton";
+    email = "plotnikovanton@gmail.com";
+    github = "pltanton";
+    githubId = 4561823;
+  };
 }

modules/misc/xdg-desktop-entries.nix

@@ -147,7 +147,7 @@ let
       extraDesktopEntries = config.settings;
     };
 in {
-  meta.maintainers = with maintainers; [ cwyc ];
+  meta.maintainers = [ hm.maintainers.cwyc ];
 
   options.xdg.desktopEntries = mkOption {
     description = ''

modules/programs/broot.nix

@@ -15,7 +15,7 @@ let
   };
 
 in {
-  meta.maintainers = [ maintainers.aheaume ];
+  meta.maintainers = [ hm.maintainers.aheaume ];
 
   options.programs.broot = {
     enable = mkEnableOption "Broot, a better way to navigate directories";

modules/programs/exa.nix

@@ -15,7 +15,7 @@ let
   };
 
 in {
-  meta.maintainers = [ maintainers.kalhauge ];
+  meta.maintainers = [ hm.maintainers.kalhauge ];
 
   options.programs.exa = {
     enable =

modules/programs/hexchat.nix

@@ -229,7 +229,7 @@ let
     ]);
 
 in {
-  meta.maintainers = with maintainers; [ superherointj thiagokokada ];
+  meta.maintainers = with maintainers; [ thiagokokada ];
 
   options.programs.hexchat = with types; {
     enable = mkEnableOption "HexChat, a graphical IRC client";

modules/programs/htop.nix

@@ -89,7 +89,7 @@ let
   blank = text "Blank";
 
 in {
-  meta.maintainers = [ maintainers.bjpbakker ];
+  meta.maintainers = [ hm.maintainers.bjpbakker ];
 
   options.programs.htop = {
     enable = mkEnableOption "htop";

modules/programs/lazygit.nix

@@ -11,7 +11,7 @@ let
   inherit (pkgs.stdenv.hostPlatform) isDarwin;
 
 in {
-  meta.maintainers = [ maintainers.kalhauge ];
+  meta.maintainers = [ hm.maintainers.kalhauge ];
 
   options.programs.lazygit = {
     enable = mkEnableOption "lazygit, a simple terminal UI for git commands";

modules/programs/ncmpcpp.nix

@@ -44,7 +44,7 @@ let
   });
 
 in {
-  meta.maintainers = with maintainers; [ olmokramer ];
+  meta.maintainers = [ hm.maintainers.olmokramer ];
 
   options.programs.ncmpcpp = {
     enable =

modules/programs/xmobar.nix

@@ -55,5 +55,5 @@ in {
     xdg.configFile."xmobar/.xmobarrc".text = cfg.extraConfig;
   };
 
-  meta.maintainers = with maintainers; [ t4ccer ];
+  meta.maintainers = [ hm.maintainers.t4ccer ];
 }

modules/services/kanshi.nix

@@ -128,7 +128,7 @@ let
     '';
 in {
 
-  meta.maintainers = [ maintainers.nurelin ];
+  meta.maintainers = [ hm.maintainers.nurelin ];
 
   options.services.kanshi = {
     enable = mkEnableOption

modules/services/pasystray.nix

@@ -3,7 +3,7 @@
 with lib;
 
 {
-  meta.maintainers = [ maintainers.pltanton ];
+  meta.maintainers = [ hm.maintainers.pltanton ];
 
   options = {
     services.pasystray = { enable = mkEnableOption "PulseAudio system tray"; };

modules/services/playerctld.nix

@@ -7,7 +7,7 @@ let
   cfg = config.services.playerctld;
 
 in {
-  meta.maintainers = [ maintainers.fendse ];
+  meta.maintainers = [ hm.maintainers.fendse ];
 
   options.services.playerctld = {
     enable = mkEnableOption "playerctld daemon";

modules/services/status-notifier-watcher.nix

@@ -7,7 +7,7 @@ let
   cfg = config.services.status-notifier-watcher;
 
 in {
-  meta.maintainers = [ maintainers.pltanton ];
+  meta.maintainers = [ hm.maintainers.pltanton ];
 
   options = {
     services.status-notifier-watcher = {

modules/services/trayer.nix

@@ -100,7 +100,7 @@ let
   cfg = config.services.trayer;
 
 in {
-  meta.maintainers = [ maintainers.mager ];
+  meta.maintainers = [ hm.maintainers.mager ];
 
   options = {
     services.trayer = {

modules/services/wlsunset.nix

@@ -5,7 +5,7 @@ with lib;
 let cfg = config.services.wlsunset;
 
 in {
-  meta.maintainers = [ maintainers.matrss ];
+  meta.maintainers = [ hm.maintainers.matrss ];
 
   options.services.wlsunset = {
     enable = mkEnableOption "Whether to enable wlsunset.";