unclechu's fork of gRPC-haskell
Find a file
intractable e1091b9c0d
grpc-haskell{-core} -> 0.2.0: Fix MetadataMap duplicate-key ordering (#132)
* Put LD_LIBRARY_PATH set back into Linux `nix-shell`

...as we need it for `ghci` workflows inside the shell(s).

* Add (failing) test case to check MetadataMap ordering

* Remove SortedList value-component from MetadataMap

...which fixes the failing test case introduced by `85a2d13`.

This is a potentially breaking change that warrants a library rev bump.

I'm not sure what the original reason was for the sorted list component of
`MetadataMap` (i.e., header values), but that implementation choice makes it so
that determining the "last provided" header value associated with a duplicate
key cannot be recovered. That is, it is in violation of this requirement from
the [spec](https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md):

```
Custom-Metadata header order is not guaranteed to be preserved except for values
with duplicate header names.
```

I'm guessing that the original motivation might have been to ensure that the Eq
instance was not sensitive to ordering of values for duplicate keys.

I think we can drop the existing `Eq` assumption about order-insensitive values
for duplicate keys (there is order sensitivity after all), and if we end up
discovering a common use case for an order-insensitive equality on values, we
should address that via a utility function (instead via the type's `Eq`
instance).

So, this commit changes the value component of the `MetadataMap` type to be a
list of `ByteString` values instead of `SortedList ByteString`, and removes the
`sorted-list` package as a dependency, as it has no other uses in the library.

Note that this commit is not claiming we are now spec-compliant w.r.t. header
treatment after this change. In particular (and at least),

1. We do not yet support base64-encoded binary data via the special `-bin` key
suffix.

2. As far as I am aware, we do not (yet) interpret comma-separated header values
the same as duplicate header keys for each of those values.

3. As far as I am aware, we do not (yet) do any validation of header names nor
whitespace handling as per the request grammar from the spec.

* Extend Arbitrary MetadataMap to explicitly encode key duplication

Duplicate keys were allowed by the previous implementation, but this commit
makes key duplication more explicit and more frequent.

* Add metadata map ordering QC prop

* Drop qualified use of @?= since it's so common in this module

* Extend checkMetadataOrdering to check instance Eq MetadataMap

...and use the appropriate bracketing wrapper.

* Relocate MetadataMap type to its own module

* Add some helper functions for MetadataMap lookup; documentation

* Extend testMetadataOrdering w/ use of lookup{All,Last}

* Bump grpc-haskell{,-core} -> 0.2.0
2021-06-30 20:32:33 -05:00
.github/workflows Switch from Travis CI to GitHub Actions (#127) 2021-06-10 15:38:15 -07:00
bench Client helpers, re-exports, and fixups (#70) 2018-10-14 17:52:59 -05:00
bin Upgrade nix grpc version to 1.0.1 + fix tests (#86) 2016-12-20 15:57:38 -06:00
core grpc-haskell{-core} -> 0.2.0: Fix MetadataMap duplicate-key ordering (#132) 2021-06-30 20:32:33 -05:00
examples Minor cleanup (#130) 2021-06-30 12:31:45 -05:00
nix Upgrade gRPC C library (#117) 2021-03-08 13:44:36 -08:00
src/Network/GRPC grpc-haskell-0.2.0.0: Upgrade to proto3-wire-1.2.0, proto3-suite-0.4.2.0 (#110) 2020-11-16 11:43:28 -06:00
tests Expose ClientCall in ClientReaderHandler and ClientRWHandler (#87) 2019-08-22 10:53:41 -05:00
.gitignore grpc-haskell-0.2.0.0: Upgrade to proto3-wire-1.2.0, proto3-suite-0.4.2.0 (#110) 2020-11-16 11:43:28 -06:00
default.nix Switch from Travis CI to GitHub Actions (#127) 2021-06-10 15:38:15 -07:00
grpc-haskell.cabal grpc-haskell{-core} -> 0.2.0: Fix MetadataMap duplicate-key ordering (#132) 2021-06-30 20:32:33 -05:00
LICENSE Fix author/maintainer/copyright in grpc-haskell.cabal (#82) 2016-12-14 12:55:56 -06:00
nixpkgs.nix Upgrade gRPC C library (#117) 2021-03-08 13:44:36 -08:00
README.md Minor cleanup (#130) 2021-06-30 12:31:45 -05:00
release.nix grpc-haskell{-core} -> 0.2.0: Fix MetadataMap duplicate-key ordering (#132) 2021-06-30 20:32:33 -05:00
Setup.hs Initial commit. 2015-02-27 18:14:32 +01:00
shell.nix Port grpc-haskell[-core] to ghc-8.6 and modern tasty. (#77) 2019-03-25 16:52:04 -07:00
stack.yaml Fix stack.yaml format to support stack 2.0 configuration (#93) 2019-09-18 08:25:00 -05:00

Attribution

This library is a fork of https://github.com/aloiscochard/grpc-haskell that we have extended and released under the same LICENSE

Installation

The current version of this library requires gRPC version 1.34.1. Newer versions may work but have not been tested.

Usage

There is a tutorial here

Building and testing

nix-build release.nix -A grpc-haskell will build and test the whole thing and put the completed package into the nix store. nix-shell can be used to give you a development environment where you can use cabal for development and testing:

$ nix-shell
[nix-shell]$ cabal configure --enable-tests && cabal build && cabal test

Using the Library

You must compile with -threaded, because we rely on being able to execute Haskell while blocking on foreign calls to the gRPC library. If not using code generation, the recommended place to start is in the Network.GRPC.HighLevel.Server.Unregistered module, where serverLoop provides a handler loop.