eeva/gRPC-haskell
1
0
Fork 0
mirror of https://github.com/unclechu/gRPC-haskell.git synced 2024-11-26 21:19:43 +01:00
Code Issues Projects Releases Wiki Activity

Mask body of runOps to avoid a heap corruption (#89)

Browse source
This commit is contained in:
Moritz Kiefer 2019-08-29 18:15:48 +02:00 committed by Gabriel Gonzalez
parent 01b17286b6
commit be70fc49b0
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/src/Network/GRPC/LowLevel/Op.hs
View file

@ -208,7 +208,14 @@ runOps :: C.Call
-> IO (Either GRPCIOError [OpRecvResult]) -> IO (Either GRPCIOError [OpRecvResult])
runOps call cq ops = runOps call cq ops =
let l = length ops in let l = length ops in
withOpArrayAndCtxts ops $ \(opArray, contexts) -> do -- It is crucial to mask exceptions here. If we don’t do this, we can
-- run into the following situation:
--
-- 1. We allocate an OpContext, e.g., OpRecvMessageContext and the corresponding ByteBuffer.
-- 2. We pass the buffer to gRPC in startBatch.
-- 3. If we now get an exception we will free the ByteBuffer.
-- 4. gRPC can now end up writing to the freed ByteBuffer and we get a heap corruption.
withOpArrayAndCtxts ops $ \(opArray, contexts) -> mask_ $ do
grpcDebug $ "runOps: allocated op contexts: " ++ show contexts grpcDebug $ "runOps: allocated op contexts: " ++ show contexts
tag <- newTag cq tag <- newTag cq
grpcDebug $ "runOps: tag: " ++ show tag grpcDebug $ "runOps: tag: " ++ show tag