From b08ae78dd151022aaa799445bce5524b7082ecf8 Mon Sep 17 00:00:00 2001 From: Joel Stanley Date: Wed, 8 Jun 2016 13:13:51 -0500 Subject: [PATCH] comments --- src/Network/GRPC/LowLevel/Client.hs | 3 +++ src/Network/GRPC/LowLevel/CompletionQueue.hs | 6 ++++++ src/Network/GRPC/LowLevel/Op.hs | 9 ++++----- src/Network/GRPC/LowLevel/Server.hs | 3 +++ 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/Network/GRPC/LowLevel/Client.hs b/src/Network/GRPC/LowLevel/Client.hs index ffa4479..b2324aa 100644 --- a/src/Network/GRPC/LowLevel/Client.hs +++ b/src/Network/GRPC/LowLevel/Client.hs @@ -1,5 +1,8 @@ {-# LANGUAGE RecordWildCards #-} +-- | This module defines data structures and operations pertaining to registered +-- clients using registered calls; for unregistered support, see +-- `Network.GRPC.LowLevel.Client.Unregistered`. module Network.GRPC.LowLevel.Client where import Control.Exception (bracket, finally) diff --git a/src/Network/GRPC/LowLevel/CompletionQueue.hs b/src/Network/GRPC/LowLevel/CompletionQueue.hs index 42aaaff..d924e05 100644 --- a/src/Network/GRPC/LowLevel/CompletionQueue.hs +++ b/src/Network/GRPC/LowLevel/CompletionQueue.hs @@ -3,6 +3,12 @@ -- cause race conditions, so we only expose functions that are thread safe. -- However, some of the functions we export here can cause memory leaks if used -- improperly. +-- +-- When definition operations which pertain to calls, this module only provides +-- definitions for registered calls; for unregistered variants, see +-- `Network.GRPC.LowLevel.CompletionQueue.Unregistered`. Type definitions and +-- implementation details to both are kept in +-- `Network.GRPC.LowLevel.CompletionQueue.Internal`. {-# LANGUAGE RecordWildCards #-} diff --git a/src/Network/GRPC/LowLevel/Op.hs b/src/Network/GRPC/LowLevel/Op.hs index 4950338..7ee0fe5 100644 --- a/src/Network/GRPC/LowLevel/Op.hs +++ b/src/Network/GRPC/LowLevel/Op.hs @@ -221,11 +221,10 @@ runOps call cq ops timeLimit = -- | For a given call, run the given 'Op's on the given completion queue with -- the given tag. Blocks until the ops are complete or the given number of --- seconds have elapsed. --- TODO: now that 'ServerRegCall' and 'U.ServerCall' are separate types, we --- could try to limit the input 'Op's more appropriately. E.g., we don't use --- an 'OpRecvInitialMetadata' when receiving a registered call, because gRPC --- handles that for us. +-- seconds have elapsed. TODO: now that we distinguish between different types +-- of calls at the type level, we could try to limit the input 'Op's more +-- appropriately. E.g., we don't use an 'OpRecvInitialMetadata' when receiving a +-- registered call, because gRPC handles that for us. runServerRegOps :: ServerRegCall -- ^ 'Call' that this batch is associated with. One call can be -- associated with many batches. diff --git a/src/Network/GRPC/LowLevel/Server.hs b/src/Network/GRPC/LowLevel/Server.hs index f34d676..9ae18a2 100644 --- a/src/Network/GRPC/LowLevel/Server.hs +++ b/src/Network/GRPC/LowLevel/Server.hs @@ -1,5 +1,8 @@ {-# LANGUAGE RecordWildCards #-} +-- | This module defines data structures and operations pertaining to registered +-- servers using registered calls; for unregistered support, see +-- `Network.GRPC.LowLevel.Server.Unregistered`. module Network.GRPC.LowLevel.Server where import Control.Exception (bracket, finally)