56b211120c
* Column spans * Row spans - The spec says that if the `val` attribute is ommitted, its value should be assumed to be `continue`, and that its values are restricted to {`restart`, `continue`}. If the value has any other value, I think it seems reasonable to default it to `continue`. It might cause problems if the spec is extended in the future by adding a third possible value, in which case this would probably give incorrect behaviour, and wouldn't error. * Allow multiple header rows * Include table description in simple caption - The table description element is like alt text for a table (along with the table caption element). It seems like we should include this somewhere, but I’m not 100% sure how – I’m pairing it with the simple caption for the moment. (Should it maybe go in the block caption instead?) * Detect table captions - Check for caption paragraph style /and/ either the simple or complex table field. This means the caption detection fails for captions which don’t contain a field, as in an example doc I added as a test. However, I think it’s better to be too conservative: a missed table caption will still show up as a paragraph next to the table, whereas if I incorrectly classify something else as a table caption it could cause havoc by pairing it up with a table it’s not at all related to, or dropping it entirely. * Update tests and add new ones Partially fixes: #6316 |
||
---|---|---|
.. | ||
golden | ||
0_level_headers.docx | ||
0_level_headers.native | ||
adjacent_codeblocks.docx | ||
adjacent_codeblocks.native | ||
already_auto_ident.docx | ||
already_auto_ident.native | ||
alternate_document_path.docx | ||
alternate_document_path.native | ||
block_quotes.docx | ||
block_quotes_parse_indent.native | ||
char_styles.docx | ||
char_styles.native | ||
codeblock.docx | ||
codeblock.native | ||
comments.docx | ||
comments.native | ||
comments_no_comments.native | ||
comments_warning.docx | ||
compact-style-removal.docx | ||
compact-style-removal.native | ||
custom-style-no-styles.native | ||
custom-style-preserve.native | ||
custom-style-reference.docx | ||
custom-style-roundtrip-end.native | ||
custom-style-with-styles.native | ||
custom_style.native | ||
deep_normalize.docx | ||
deep_normalize.native | ||
definition_list.docx | ||
definition_list.native | ||
document-properties-short-desc.native | ||
document-properties.native | ||
drop_cap.docx | ||
drop_cap.native | ||
dummy_item_after_list_item.docx | ||
dummy_item_after_list_item.native | ||
dummy_item_after_paragraph.docx | ||
dummy_item_after_paragraph.native | ||
enumerated_headings.docx | ||
enumerated_headings.native | ||
german_styled_lists.docx | ||
german_styled_lists.native | ||
hanging_indent.docx | ||
hanging_indent.native | ||
headers.docx | ||
headers.native | ||
i18n_blocks.docx | ||
i18n_blocks.native | ||
image.docx | ||
image_no_embed.native | ||
image_no_embed_writer.native | ||
image_vml.docx | ||
image_vml.native | ||
image_vml_as_object.docx | ||
image_vml_as_object.native | ||
image_writer_test.native | ||
inline_code.docx | ||
inline_code.native | ||
inline_formatting.docx | ||
inline_formatting.native | ||
inline_formatting_writer.native | ||
inline_images.docx | ||
inline_images.native | ||
inline_images_writer.native | ||
inline_images_writer_test.native | ||
instrText_hyperlink.docx | ||
instrText_hyperlink.native | ||
link_in_notes.docx | ||
link_in_notes.native | ||
links.docx | ||
links.native | ||
links_writer.native | ||
lists-compact.docx | ||
lists-compact.native | ||
lists.docx | ||
lists.native | ||
lists_continuing.docx | ||
lists_continuing.native | ||
lists_level_override.docx | ||
lists_level_override.native | ||
lists_multiple_initial.native | ||
lists_restarting.docx | ||
lists_restarting.native | ||
lists_sublist_reset.docx | ||
lists_sublist_reset.native | ||
lists_writer.native | ||
metadata.docx | ||
metadata.native | ||
metadata_after_normal.docx | ||
metadata_after_normal.native | ||
nested_anchors_in_header.docx | ||
nested_anchors_in_header.native | ||
nested_sdt.docx | ||
nested_sdt.native | ||
nested_smart_tags.docx | ||
nested_smart_tags.native | ||
normalize.docx | ||
normalize.native | ||
notes.docx | ||
notes.native | ||
numbered_header.docx | ||
numbered_header.native | ||
overlapping_targets.docx | ||
overlapping_targets.native | ||
paragraph_insertion_deletion.docx | ||
paragraph_insertion_deletion_accept.native | ||
paragraph_insertion_deletion_all.native | ||
paragraph_insertion_deletion_reject.native | ||
raw-blocks.native | ||
raw-bookmarks.native | ||
sdt_elements.docx | ||
sdt_elements.native | ||
sdt_in_footnote.docx | ||
sdt_in_footnote.native | ||
special_punctuation.docx | ||
special_punctuation.native | ||
table_captions_no_field.docx | ||
table_captions_no_field.native | ||
table_captions_with_field.docx | ||
table_captions_with_field.native | ||
table_header_rowspan.docx | ||
table_header_rowspan.native | ||
table_one_header_row.docx | ||
table_one_header_row.native | ||
table_one_row.docx | ||
table_one_row.native | ||
table_variable_width.docx | ||
table_variable_width.native | ||
table_with_list_cell.docx | ||
table_with_list_cell.native | ||
tables-default-widths.native | ||
tables.docx | ||
tables.native | ||
tabs.docx | ||
tabs.native | ||
track_changes_deletion.docx | ||
track_changes_deletion_accept.native | ||
track_changes_deletion_all.native | ||
track_changes_deletion_reject.native | ||
track_changes_insertion.docx | ||
track_changes_insertion_accept.native | ||
track_changes_insertion_all.native | ||
track_changes_insertion_reject.native | ||
track_changes_move.docx | ||
track_changes_move_accept.native | ||
track_changes_move_all.native | ||
track_changes_move_reject.native | ||
track_changes_scrubbed_metadata.docx | ||
track_changes_scrubbed_metadata.native | ||
trailing_spaces_in_formatting.docx | ||
trailing_spaces_in_formatting.native | ||
trim_last_inline.docx | ||
trim_last_inline.native | ||
unicode.docx | ||
unicode.native | ||
unused_anchors.docx | ||
unused_anchors.native | ||
verbatim_subsuper.docx | ||
verbatim_subsuper.native |