Tissevert/pandoc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Man writer: suppress non-absolute link URLs.

Browse source 
Motivation: in a man page there's not much use for relative URLs,
which you can't follow.  Absolute URLs are still useful.  We previously
suppressed relative URLs starting with '#' (purely internal links),
but it makes sense to go a bit farther.

Closes #5770.
This commit is contained in:
John MacFarlane 2019-09-23 17:46:39 -07:00
parent e99050283e
commit f223196c35
2 changed files with 25 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Text/Pandoc/Writers/Man.hs
View file

@ -310,9 +310,9 @@ inlineToMan _ LineBreak = return $
cr <> text ".PD 0" $$ text ".P" $$ text ".PD" <> cr
inlineToMan _ SoftBreak = return space
inlineToMan _ Space = return space
inlineToMan opts (Link _ txt ('#':_, _)) =
inlineListToMan opts txt -- skip internal links
inlineToMan opts (Link _ txt (src, _)) = do
inlineToMan opts (Link _ txt (src, _))
| not (isURI src) = inlineListToMan opts txt -- skip relative links
| otherwise = do
linktext <- inlineListToMan opts txt
let srcSuffix = fromMaybe src (stripPrefix "mailto:" src)
return $ case txt of

44
test/writer.man
View file

@ -6,7 +6,7 @@ Most of them are adapted from John Gruber\[cq]s markdown test suite.
.PP
* * * * *
.SH Headers
.SS Level 2 with an embedded link (/url)
.SS Level 2 with an embedded link
.SS Level 3 with \f[I]emphasis\f[R]
.SS Level 4
.SS Level 5
@ -477,7 +477,7 @@ This is \f[I]emphasized\f[R], and so \f[I]is this\f[R].
.PP
This is \f[B]strong\f[R], and so \f[B]is this\f[R].
.PP
An \f[I]emphasized link (/url)\f[R].
An \f[I]emphasized link\f[R].
.PP
\f[B]\f[BI]This is strong and em.\f[B]\f[R]
.PP
@ -618,36 +618,36 @@ Minus: -
.SH Links
.SS Explicit
.PP
Just a URL (/url/).
Just a URL.
.PP
URL and title (/url/).
URL and title.
.PP
URL and title (/url/).
URL and title.
.PP
URL and title (/url/).
URL and title.
.PP
URL and title (/url/)
URL and title
.PP
URL and title (/url/)
URL and title
.PP
with_underscore (/url/with_underscore)
with_underscore
.PP
Email link (mailto:nobody@nowhere.net)
.PP
Empty ().
Empty.
.SS Reference
.PP
Foo bar (/url/).
Foo bar.
.PP
With embedded [brackets] (/url/).
With embedded [brackets].
.PP
b (/url/) by itself should be a link.
b by itself should be a link.
.PP
Indented once (/url).
Indented once.
.PP
Indented twice (/url).
Indented twice.
.PP
Indented thrice (/url).
Indented thrice.
.PP
This should [not][] be a link.
.IP
@ -657,9 +657,9 @@ This should [not][] be a link.
\f[R]
.fi
.PP
Foo bar (/url/).
Foo bar.
.PP
Foo biz (/url/).
Foo biz.
.SS With ampersands
.PP
Here\[cq]s a link with an ampersand in the
@ -667,9 +667,9 @@ URL (http://example.com/?foo=1&bar=2).
.PP
Here\[cq]s a link with an amersand in the link text: AT&T (http://att.com/).
.PP
Here\[cq]s an inline link (/script?foo=1&bar=2).
Here\[cq]s an inline link.
.PP
Here\[cq]s an inline link in pointy braces (/script?foo=1&bar=2).
Here\[cq]s an inline link in pointy braces.
.SS Autolinks
.PP
With an ampersand: <http://example.com/?foo=1&bar=2>
@ -699,9 +699,9 @@ or here: <http://example.com/>
.PP
From \[lq]Voyage dans la Lune\[rq] by Georges Melies (1902):
.PP
[IMAGE: lalune (lalune.jpg)]
[IMAGE: lalune]
.PP
Here is a movie [IMAGE: movie (movie.jpg)] icon.
Here is a movie [IMAGE: movie] icon.
.PP
* * * * *
.SH Footnotes